Date Comparison Function for `usort()` (PHP)












0














I am working through a PHP book, and date comparison was mentioned as one of the uses of usort(), so I wrote a date comparison function to use in line with usort. Writing the function wasn't as easy as I expected (there was a pesky bug which took me a while to identify), so I thought I would submit my comparison code for review.



dates.php



<?
function dateParse($date)
{
return (count(explode("-", $date)) == 3)?(explode("-", $date)):(explode("/", $date)); #Returns the date as an array.
}

function dateSort($date1, $date2, $format=1)
{
if ($format == 0) #dd/mm/yyyy format.
{
list($day1, $month1, $year1) = dateParse($date1);
list($day2, $month2, $year2) = dateParse($date2);
}
elseif ($format == 1) #mm/dd/yyyy format.
{
list($month1, $day1, $year1) = dateParse($date1);
list($month2, $day2, $year2) = dateParse($date2);
}
elseif ($format == 2) #yyyy/mm/dd format.
{
list($year1, $month1, $day1) = dateParse($date1);
list($year2, $month2, $day2) = dateParse($date2);
}
$day1 = str_pad($day1, 2, "0", STR_PAD_LEFT); #Adds a leading "0" if the day is a single digit.
$day2 = str_pad($day2, 2, "0", STR_PAD_LEFT); #Adds a leading "0" if the day is a single digit.
$month1 = str_pad($month1, 2, "0", STR_PAD_LEFT); #Adds a leading "0" if the month is a single digit.
$month2 = str_pad($month2, 2, "0", STR_PAD_LEFT); #Adds a leading "0" if the month is a single digit.

$x1 = $year1.$month1.$day1;
$x2 = $year2.$month2.$day2;

return ((int)$x1 <=> (int)$x2);
}
?>









share|improve this question



























    0














    I am working through a PHP book, and date comparison was mentioned as one of the uses of usort(), so I wrote a date comparison function to use in line with usort. Writing the function wasn't as easy as I expected (there was a pesky bug which took me a while to identify), so I thought I would submit my comparison code for review.



    dates.php



    <?
    function dateParse($date)
    {
    return (count(explode("-", $date)) == 3)?(explode("-", $date)):(explode("/", $date)); #Returns the date as an array.
    }

    function dateSort($date1, $date2, $format=1)
    {
    if ($format == 0) #dd/mm/yyyy format.
    {
    list($day1, $month1, $year1) = dateParse($date1);
    list($day2, $month2, $year2) = dateParse($date2);
    }
    elseif ($format == 1) #mm/dd/yyyy format.
    {
    list($month1, $day1, $year1) = dateParse($date1);
    list($month2, $day2, $year2) = dateParse($date2);
    }
    elseif ($format == 2) #yyyy/mm/dd format.
    {
    list($year1, $month1, $day1) = dateParse($date1);
    list($year2, $month2, $day2) = dateParse($date2);
    }
    $day1 = str_pad($day1, 2, "0", STR_PAD_LEFT); #Adds a leading "0" if the day is a single digit.
    $day2 = str_pad($day2, 2, "0", STR_PAD_LEFT); #Adds a leading "0" if the day is a single digit.
    $month1 = str_pad($month1, 2, "0", STR_PAD_LEFT); #Adds a leading "0" if the month is a single digit.
    $month2 = str_pad($month2, 2, "0", STR_PAD_LEFT); #Adds a leading "0" if the month is a single digit.

    $x1 = $year1.$month1.$day1;
    $x2 = $year2.$month2.$day2;

    return ((int)$x1 <=> (int)$x2);
    }
    ?>









    share|improve this question

























      0












      0








      0







      I am working through a PHP book, and date comparison was mentioned as one of the uses of usort(), so I wrote a date comparison function to use in line with usort. Writing the function wasn't as easy as I expected (there was a pesky bug which took me a while to identify), so I thought I would submit my comparison code for review.



      dates.php



      <?
      function dateParse($date)
      {
      return (count(explode("-", $date)) == 3)?(explode("-", $date)):(explode("/", $date)); #Returns the date as an array.
      }

      function dateSort($date1, $date2, $format=1)
      {
      if ($format == 0) #dd/mm/yyyy format.
      {
      list($day1, $month1, $year1) = dateParse($date1);
      list($day2, $month2, $year2) = dateParse($date2);
      }
      elseif ($format == 1) #mm/dd/yyyy format.
      {
      list($month1, $day1, $year1) = dateParse($date1);
      list($month2, $day2, $year2) = dateParse($date2);
      }
      elseif ($format == 2) #yyyy/mm/dd format.
      {
      list($year1, $month1, $day1) = dateParse($date1);
      list($year2, $month2, $day2) = dateParse($date2);
      }
      $day1 = str_pad($day1, 2, "0", STR_PAD_LEFT); #Adds a leading "0" if the day is a single digit.
      $day2 = str_pad($day2, 2, "0", STR_PAD_LEFT); #Adds a leading "0" if the day is a single digit.
      $month1 = str_pad($month1, 2, "0", STR_PAD_LEFT); #Adds a leading "0" if the month is a single digit.
      $month2 = str_pad($month2, 2, "0", STR_PAD_LEFT); #Adds a leading "0" if the month is a single digit.

      $x1 = $year1.$month1.$day1;
      $x2 = $year2.$month2.$day2;

      return ((int)$x1 <=> (int)$x2);
      }
      ?>









      share|improve this question













      I am working through a PHP book, and date comparison was mentioned as one of the uses of usort(), so I wrote a date comparison function to use in line with usort. Writing the function wasn't as easy as I expected (there was a pesky bug which took me a while to identify), so I thought I would submit my comparison code for review.



      dates.php



      <?
      function dateParse($date)
      {
      return (count(explode("-", $date)) == 3)?(explode("-", $date)):(explode("/", $date)); #Returns the date as an array.
      }

      function dateSort($date1, $date2, $format=1)
      {
      if ($format == 0) #dd/mm/yyyy format.
      {
      list($day1, $month1, $year1) = dateParse($date1);
      list($day2, $month2, $year2) = dateParse($date2);
      }
      elseif ($format == 1) #mm/dd/yyyy format.
      {
      list($month1, $day1, $year1) = dateParse($date1);
      list($month2, $day2, $year2) = dateParse($date2);
      }
      elseif ($format == 2) #yyyy/mm/dd format.
      {
      list($year1, $month1, $day1) = dateParse($date1);
      list($year2, $month2, $day2) = dateParse($date2);
      }
      $day1 = str_pad($day1, 2, "0", STR_PAD_LEFT); #Adds a leading "0" if the day is a single digit.
      $day2 = str_pad($day2, 2, "0", STR_PAD_LEFT); #Adds a leading "0" if the day is a single digit.
      $month1 = str_pad($month1, 2, "0", STR_PAD_LEFT); #Adds a leading "0" if the month is a single digit.
      $month2 = str_pad($month2, 2, "0", STR_PAD_LEFT); #Adds a leading "0" if the month is a single digit.

      $x1 = $year1.$month1.$day1;
      $x2 = $year2.$month2.$day2;

      return ((int)$x1 <=> (int)$x2);
      }
      ?>






      beginner php






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 23 mins ago









      Tobi Alafin

      1835




      1835



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210732%2fdate-comparison-function-for-usort-php%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210732%2fdate-comparison-function-for-usort-php%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Morgemoulin

          Scott Moir

          Souastre