Displaying Singapore bus arrival times using a Go template
I am wondering whether my template usage in main.go could be better. For example in other code I notice:
var views = template.Must(template.ParseGlob("static/*.tmpl"))
Defined outside main, hence the templates are loaded on process start. And then in the handler:
views.ExecuteTemplate(w, "passwordprompt.tmpl", map[string]interface{}{})
In my own code, I am wondering if it is worth applying the same practice. Is it possible with functions & the code below?
func handleIndex(w http.ResponseWriter, r *http.Request) {
funcs := template.FuncMap{
"nameBusStopID": func(s string) string { return bs.nameBusStopID(s) },
"getenv": os.Getenv,
}
t, err := template.New("").Funcs(funcs).ParseFiles("templates/index.html")
if err != nil {
log.WithError(err).Error("template failed to parse")
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
arriving, err := busArrivals(r.URL.Query().Get("id"))
if err != nil {
log.WithError(err).Error("failed to retrieve bus timings")
}
t.ExecuteTemplate(w, "index.html", arriving)
}
Please feel free to critique all the code.
html go template
edited 2 hours ago
200_success
128k15150412
asked 16 hours ago
Kai Hendry
73314
add a comment |
I am wondering whether my template usage in main.go could be better. For example in other code I notice:
var views = template.Must(template.ParseGlob("static/*.tmpl"))
Defined outside main, hence the templates are loaded on process start. And then in the handler:
views.ExecuteTemplate(w, "passwordprompt.tmpl", map[string]interface{}{})
In my own code, I am wondering if it is worth applying the same practice. Is it possible with functions & the code below?
func handleIndex(w http.ResponseWriter, r *http.Request) {
funcs := template.FuncMap{
"nameBusStopID": func(s string) string { return bs.nameBusStopID(s) },
"getenv": os.Getenv,
}
t, err := template.New("").Funcs(funcs).ParseFiles("templates/index.html")
if err != nil {
log.WithError(err).Error("template failed to parse")
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
arriving, err := busArrivals(r.URL.Query().Get("id"))
if err != nil {
log.WithError(err).Error("failed to retrieve bus timings")
}
t.ExecuteTemplate(w, "index.html", arriving)
}
Please feel free to critique all the code.
html go template
edited 2 hours ago
200_success
128k15150412
asked 16 hours ago
Kai Hendry
73314
1
Could you add an explanation of your code's purpose to the body of your question, and edit your question title to reflect it?
– Graham
8 hours ago
add a comment |
I am wondering whether my template usage in main.go could be better. For example in other code I notice:
var views = template.Must(template.ParseGlob("static/*.tmpl"))
Defined outside main, hence the templates are loaded on process start. And then in the handler:
views.ExecuteTemplate(w, "passwordprompt.tmpl", map[string]interface{}{})
In my own code, I am wondering if it is worth applying the same practice. Is it possible with functions & the code below?
func handleIndex(w http.ResponseWriter, r *http.Request) {
funcs := template.FuncMap{
"nameBusStopID": func(s string) string { return bs.nameBusStopID(s) },
"getenv": os.Getenv,
}
t, err := template.New("").Funcs(funcs).ParseFiles("templates/index.html")
if err != nil {
log.WithError(err).Error("template failed to parse")
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
arriving, err := busArrivals(r.URL.Query().Get("id"))
if err != nil {
log.WithError(err).Error("failed to retrieve bus timings")
}
t.ExecuteTemplate(w, "index.html", arriving)
}
Please feel free to critique all the code.
html go template
edited 2 hours ago
200_success
128k15150412
asked 16 hours ago
Kai Hendry
73314
I am wondering whether my template usage in main.go could be better. For example in other code I notice:
var views = template.Must(template.ParseGlob("static/*.tmpl"))
Defined outside main, hence the templates are loaded on process start. And then in the handler:
views.ExecuteTemplate(w, "passwordprompt.tmpl", map[string]interface{}{})
In my own code, I am wondering if it is worth applying the same practice. Is it possible with functions & the code below?
func handleIndex(w http.ResponseWriter, r *http.Request) {
funcs := template.FuncMap{
"nameBusStopID": func(s string) string { return bs.nameBusStopID(s) },
"getenv": os.Getenv,
}
t, err := template.New("").Funcs(funcs).ParseFiles("templates/index.html")
if err != nil {
log.WithError(err).Error("template failed to parse")
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
arriving, err := busArrivals(r.URL.Query().Get("id"))
if err != nil {
log.WithError(err).Error("failed to retrieve bus timings")
}
t.ExecuteTemplate(w, "index.html", arriving)
}
Please feel free to critique all the code.
html go template
html go template
edited 2 hours ago
200_success
128k15150412
asked 16 hours ago
Kai Hendry
73314
edited 2 hours ago
200_success
128k15150412
asked 16 hours ago
Kai Hendry
73314
edited 2 hours ago
200_success
128k15150412
edited 2 hours ago
200_success
128k15150412
edited 2 hours ago
200_success
128k15150412
128k15150412
asked 16 hours ago
Kai Hendry
73314
asked 16 hours ago
Kai Hendry
73314
asked 16 hours ago
Kai Hendry
73314
73314
1
Could you add an explanation of your code's purpose to the body of your question, and edit your question title to reflect it?
– Graham
8 hours ago
add a comment |
1
Could you add an explanation of your code's purpose to the body of your question, and edit your question title to reflect it?
– Graham
8 hours ago
1
1
Could you add an explanation of your code's purpose to the body of your question, and edit your question title to reflect it?
– Graham
8 hours ago
Could you add an explanation of your code's purpose to the body of your question, and edit your question title to reflect it?
– Graham
8 hours ago
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210589%2fdisplaying-singapore-bus-arrival-times-using-a-go-template%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210589%2fdisplaying-singapore-bus-arrival-times-using-a-go-template%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
Could you add an explanation of your code's purpose to the body of your question, and edit your question title to reflect it?
– Graham
8 hours ago