Dynamic PHP PDO insert method
1
This is my attempt at making a class for dynamic PDO queries in PHP.
The code works, but I would like the hear what I can improve to make it more secure and readable.
class DB
{
private static $connection;
public static function setConnection ($connection)
{
static::$connection = $connection;
}
public static function insert($table, $data = )
{
try {
$columnsArray = array_keys($data);
$columnsString = implode(',', $columnsArray);
$valuesArray = array_values($data);
$valuesCount = count($valuesArray);
$valuesPlaceholder = '';
for ($i=0; $i < $valuesCount; $i++) {
$valuesPlaceholder .= '?,';
}
$valuesPlaceholder = rtrim($valuesPlaceholder, ',');
$query = "INSERT INTO $table ($columnsString) VALUES ($valuesPlaceholder)";
$statement = static::$connection->prepare($query);
$statement->execute($valuesArray);
} catch (PDOException $e) {
die("Insert failed: " . $e->getMessage());
}
}
}
php object-oriented database pdo
edited 2 hours ago
200_success
128k15150412
asked 2 hours ago
failedCoder
62
New contributor
failedCoder is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
1
This is my attempt at making a class for dynamic PDO queries in PHP.
The code works, but I would like the hear what I can improve to make it more secure and readable.
class DB
{
private static $connection;
public static function setConnection ($connection)
{
static::$connection = $connection;
}
public static function insert($table, $data = )
{
try {
$columnsArray = array_keys($data);
$columnsString = implode(',', $columnsArray);
$valuesArray = array_values($data);
$valuesCount = count($valuesArray);
$valuesPlaceholder = '';
for ($i=0; $i < $valuesCount; $i++) {
$valuesPlaceholder .= '?,';
}
$valuesPlaceholder = rtrim($valuesPlaceholder, ',');
$query = "INSERT INTO $table ($columnsString) VALUES ($valuesPlaceholder)";
$statement = static::$connection->prepare($query);
$statement->execute($valuesArray);
} catch (PDOException $e) {
die("Insert failed: " . $e->getMessage());
}
}
}
php object-oriented database pdo
edited 2 hours ago
200_success
128k15150412
asked 2 hours ago
failedCoder
62
New contributor
failedCoder is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
1
1
1
This is my attempt at making a class for dynamic PDO queries in PHP.
The code works, but I would like the hear what I can improve to make it more secure and readable.
class DB
{
private static $connection;
public static function setConnection ($connection)
{
static::$connection = $connection;
}
public static function insert($table, $data = )
{
try {
$columnsArray = array_keys($data);
$columnsString = implode(',', $columnsArray);
$valuesArray = array_values($data);
$valuesCount = count($valuesArray);
$valuesPlaceholder = '';
for ($i=0; $i < $valuesCount; $i++) {
$valuesPlaceholder .= '?,';
}
$valuesPlaceholder = rtrim($valuesPlaceholder, ',');
$query = "INSERT INTO $table ($columnsString) VALUES ($valuesPlaceholder)";
$statement = static::$connection->prepare($query);
$statement->execute($valuesArray);
} catch (PDOException $e) {
die("Insert failed: " . $e->getMessage());
}
}
}
php object-oriented database pdo
edited 2 hours ago
200_success
128k15150412
asked 2 hours ago
failedCoder
62
New contributor
failedCoder is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
This is my attempt at making a class for dynamic PDO queries in PHP.
The code works, but I would like the hear what I can improve to make it more secure and readable.
class DB
{
private static $connection;
public static function setConnection ($connection)
{
static::$connection = $connection;
}
public static function insert($table, $data = )
{
try {
$columnsArray = array_keys($data);
$columnsString = implode(',', $columnsArray);
$valuesArray = array_values($data);
$valuesCount = count($valuesArray);
$valuesPlaceholder = '';
for ($i=0; $i < $valuesCount; $i++) {
$valuesPlaceholder .= '?,';
}
$valuesPlaceholder = rtrim($valuesPlaceholder, ',');
$query = "INSERT INTO $table ($columnsString) VALUES ($valuesPlaceholder)";
$statement = static::$connection->prepare($query);
$statement->execute($valuesArray);
} catch (PDOException $e) {
die("Insert failed: " . $e->getMessage());
}
}
}
php object-oriented database pdo
php object-oriented database pdo
edited 2 hours ago
200_success
128k15150412
asked 2 hours ago
failedCoder
62
New contributor
failedCoder is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 2 hours ago
200_success
128k15150412
asked 2 hours ago
failedCoder
62
New contributor
failedCoder is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 2 hours ago
200_success
128k15150412
edited 2 hours ago
200_success
128k15150412
edited 2 hours ago
200_success
128k15150412
128k15150412
asked 2 hours ago
failedCoder
62
New contributor
failedCoder is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 2 hours ago
failedCoder
62
asked 2 hours ago
failedCoder
62
62
New contributor
failedCoder is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
failedCoder is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
failedCoder is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
failedCoder is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210610%2fdynamic-php-pdo-insert-method%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
failedCoder is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
failedCoder is a new contributor. Be nice, and check out our Code of Conduct.
failedCoder is a new contributor. Be nice, and check out our Code of Conduct.
failedCoder is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210610%2fdynamic-php-pdo-insert-method%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
