Dynamically allocate a string matrix in C using struct
I've created a code that reads line by line from a file and stores all the data in a string matrix allocated using structs. But I have a memory problem. Here is the code:
struct MyStruct
{
char **cuvinte;
int nr_cuvinte;
char *linie;
};
int function(struct MyStruct **text, FILE *p, char *filename) {
int i = 0;
char buff[1024];
text = NULL;
while (!feof(p))
{
fgets(buff, 1024, p);
int j = 0;
if (text== NULL)
text= (struct MyStruct **)malloc(sizeof(text)*(i + 1));
else {
text= (struct MyStruct **)realloc(text, sizeof(struct MyStruct)*(i + 1));
}
/*
text[i]->linie = (char *)malloc(strlen(buff)+1);
strcpy(text[i]->linie, buff);*/
char *p = strtok(buff, " ");
text[i]->cuvinte = NULL;
while (p)
{
if (text[i]->cuvinte == NULL)
text[i]->cuvinte = (char **)malloc(sizeof(char *));
else
{
text[i]->cuvinte = (char **)realloc(text[i], sizeof(char *)*(j + 1));
}
text[i]->cuvinte[j] = _strdup(p);
text[i]->nr_cuvinte++;
j++;
p = strtok(NULL, " ");
}
i++;
}
int nr_linii = i-1;
return nr_linii;
}
c
New contributor
add a comment |
I've created a code that reads line by line from a file and stores all the data in a string matrix allocated using structs. But I have a memory problem. Here is the code:
struct MyStruct
{
char **cuvinte;
int nr_cuvinte;
char *linie;
};
int function(struct MyStruct **text, FILE *p, char *filename) {
int i = 0;
char buff[1024];
text = NULL;
while (!feof(p))
{
fgets(buff, 1024, p);
int j = 0;
if (text== NULL)
text= (struct MyStruct **)malloc(sizeof(text)*(i + 1));
else {
text= (struct MyStruct **)realloc(text, sizeof(struct MyStruct)*(i + 1));
}
/*
text[i]->linie = (char *)malloc(strlen(buff)+1);
strcpy(text[i]->linie, buff);*/
char *p = strtok(buff, " ");
text[i]->cuvinte = NULL;
while (p)
{
if (text[i]->cuvinte == NULL)
text[i]->cuvinte = (char **)malloc(sizeof(char *));
else
{
text[i]->cuvinte = (char **)realloc(text[i], sizeof(char *)*(j + 1));
}
text[i]->cuvinte[j] = _strdup(p);
text[i]->nr_cuvinte++;
j++;
p = strtok(NULL, " ");
}
i++;
}
int nr_linii = i-1;
return nr_linii;
}
c
New contributor
Firstly, you haven't told us what the memory problem is. Even if you did, if the problem renders the program unusable, it's off-topic for this site and you need to instead post to StackOverflow.
– Reinderien
5 mins ago
add a comment |
I've created a code that reads line by line from a file and stores all the data in a string matrix allocated using structs. But I have a memory problem. Here is the code:
struct MyStruct
{
char **cuvinte;
int nr_cuvinte;
char *linie;
};
int function(struct MyStruct **text, FILE *p, char *filename) {
int i = 0;
char buff[1024];
text = NULL;
while (!feof(p))
{
fgets(buff, 1024, p);
int j = 0;
if (text== NULL)
text= (struct MyStruct **)malloc(sizeof(text)*(i + 1));
else {
text= (struct MyStruct **)realloc(text, sizeof(struct MyStruct)*(i + 1));
}
/*
text[i]->linie = (char *)malloc(strlen(buff)+1);
strcpy(text[i]->linie, buff);*/
char *p = strtok(buff, " ");
text[i]->cuvinte = NULL;
while (p)
{
if (text[i]->cuvinte == NULL)
text[i]->cuvinte = (char **)malloc(sizeof(char *));
else
{
text[i]->cuvinte = (char **)realloc(text[i], sizeof(char *)*(j + 1));
}
text[i]->cuvinte[j] = _strdup(p);
text[i]->nr_cuvinte++;
j++;
p = strtok(NULL, " ");
}
i++;
}
int nr_linii = i-1;
return nr_linii;
}
c
New contributor
I've created a code that reads line by line from a file and stores all the data in a string matrix allocated using structs. But I have a memory problem. Here is the code:
struct MyStruct
{
char **cuvinte;
int nr_cuvinte;
char *linie;
};
int function(struct MyStruct **text, FILE *p, char *filename) {
int i = 0;
char buff[1024];
text = NULL;
while (!feof(p))
{
fgets(buff, 1024, p);
int j = 0;
if (text== NULL)
text= (struct MyStruct **)malloc(sizeof(text)*(i + 1));
else {
text= (struct MyStruct **)realloc(text, sizeof(struct MyStruct)*(i + 1));
}
/*
text[i]->linie = (char *)malloc(strlen(buff)+1);
strcpy(text[i]->linie, buff);*/
char *p = strtok(buff, " ");
text[i]->cuvinte = NULL;
while (p)
{
if (text[i]->cuvinte == NULL)
text[i]->cuvinte = (char **)malloc(sizeof(char *));
else
{
text[i]->cuvinte = (char **)realloc(text[i], sizeof(char *)*(j + 1));
}
text[i]->cuvinte[j] = _strdup(p);
text[i]->nr_cuvinte++;
j++;
p = strtok(NULL, " ");
}
i++;
}
int nr_linii = i-1;
return nr_linii;
}
c
c
New contributor
New contributor
New contributor
asked 9 mins ago
Andre
1
1
New contributor
New contributor
Firstly, you haven't told us what the memory problem is. Even if you did, if the problem renders the program unusable, it's off-topic for this site and you need to instead post to StackOverflow.
– Reinderien
5 mins ago
add a comment |
Firstly, you haven't told us what the memory problem is. Even if you did, if the problem renders the program unusable, it's off-topic for this site and you need to instead post to StackOverflow.
– Reinderien
5 mins ago
Firstly, you haven't told us what the memory problem is. Even if you did, if the problem renders the program unusable, it's off-topic for this site and you need to instead post to StackOverflow.
– Reinderien
5 mins ago
Firstly, you haven't told us what the memory problem is. Even if you did, if the problem renders the program unusable, it's off-topic for this site and you need to instead post to StackOverflow.
– Reinderien
5 mins ago
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Andre is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210696%2fdynamically-allocate-a-string-matrix-in-c-using-struct%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Andre is a new contributor. Be nice, and check out our Code of Conduct.
Andre is a new contributor. Be nice, and check out our Code of Conduct.
Andre is a new contributor. Be nice, and check out our Code of Conduct.
Andre is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210696%2fdynamically-allocate-a-string-matrix-in-c-using-struct%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Firstly, you haven't told us what the memory problem is. Even if you did, if the problem renders the program unusable, it's off-topic for this site and you need to instead post to StackOverflow.
– Reinderien
5 mins ago