Handling USB endpoint Zero Length Packet request in Linux Kernel USB driver
up vote
0
down vote
favorite
I have a test app which basically sends block of characters over USB by using NCM connection.
When packet size is exact 512 bytes i see NCM is getting hung. By analyzing further i have found that it is related to handling usb endpoint ZLP request.
From open source i have found one link whic has fix for ZLP request,
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/usb/dwc3/gadget.c?h=v4.9.138&id=04c03d10e507052cfce6910ddf34091196e79e1c
By taking the changes mentioned in above link i could solve the problem.
Code change which mentioned in the link has the USB EP request length is set to ZERO but ZLP buffer has been allocated of 1024 bytes.
+ request->length = 0;
+ request->buf = dwc->zlp_buf;
Is this allocating 1024 bytes of ZLP buffer required? What is the purpose of this buffer if request->length = 0;?
linux-kernel drivers usb usb-device
asked Dec 5 at 9:03
Shivaprasad A Prabhu
316
add a comment |
up vote
0
down vote
favorite
I have a test app which basically sends block of characters over USB by using NCM connection.
When packet size is exact 512 bytes i see NCM is getting hung. By analyzing further i have found that it is related to handling usb endpoint ZLP request.
From open source i have found one link whic has fix for ZLP request,
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/usb/dwc3/gadget.c?h=v4.9.138&id=04c03d10e507052cfce6910ddf34091196e79e1c
By taking the changes mentioned in above link i could solve the problem.
Code change which mentioned in the link has the USB EP request length is set to ZERO but ZLP buffer has been allocated of 1024 bytes.
+ request->length = 0;
+ request->buf = dwc->zlp_buf;
Is this allocating 1024 bytes of ZLP buffer required? What is the purpose of this buffer if request->length = 0;?
linux-kernel drivers usb usb-device
asked Dec 5 at 9:03
Shivaprasad A Prabhu
316
add a comment |
up vote
0
down vote
favorite
up vote
0
down vote
favorite
I have a test app which basically sends block of characters over USB by using NCM connection.
When packet size is exact 512 bytes i see NCM is getting hung. By analyzing further i have found that it is related to handling usb endpoint ZLP request.
From open source i have found one link whic has fix for ZLP request,
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/usb/dwc3/gadget.c?h=v4.9.138&id=04c03d10e507052cfce6910ddf34091196e79e1c
By taking the changes mentioned in above link i could solve the problem.
Code change which mentioned in the link has the USB EP request length is set to ZERO but ZLP buffer has been allocated of 1024 bytes.
+ request->length = 0;
+ request->buf = dwc->zlp_buf;
Is this allocating 1024 bytes of ZLP buffer required? What is the purpose of this buffer if request->length = 0;?
linux-kernel drivers usb usb-device
asked Dec 5 at 9:03
Shivaprasad A Prabhu
316
I have a test app which basically sends block of characters over USB by using NCM connection.
When packet size is exact 512 bytes i see NCM is getting hung. By analyzing further i have found that it is related to handling usb endpoint ZLP request.
From open source i have found one link whic has fix for ZLP request,
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/usb/dwc3/gadget.c?h=v4.9.138&id=04c03d10e507052cfce6910ddf34091196e79e1c
By taking the changes mentioned in above link i could solve the problem.
Code change which mentioned in the link has the USB EP request length is set to ZERO but ZLP buffer has been allocated of 1024 bytes.
+ request->length = 0;
+ request->buf = dwc->zlp_buf;
Is this allocating 1024 bytes of ZLP buffer required? What is the purpose of this buffer if request->length = 0;?
linux-kernel drivers usb usb-device
linux-kernel drivers usb usb-device
asked Dec 5 at 9:03
Shivaprasad A Prabhu
316
asked Dec 5 at 9:03
Shivaprasad A Prabhu
316
asked Dec 5 at 9:03
Shivaprasad A Prabhu
316
asked Dec 5 at 9:03
Shivaprasad A Prabhu
316
asked Dec 5 at 9:03
Shivaprasad A Prabhu
316
316
add a comment |
add a comment |
active
oldest
votes
Your Answer
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "106"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2funix.stackexchange.com%2fquestions%2f486101%2fhandling-usb-endpoint-zero-length-packet-request-in-linux-kernel-usb-driver%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Unix & Linux Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2funix.stackexchange.com%2fquestions%2f486101%2fhandling-usb-endpoint-zero-length-packet-request-in-linux-kernel-usb-driver%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
