Pure JS countdown clock not converting millisecond time correctly
I have a semisimple pure js countdown clock that I am having trouble converting the millisecond time correctly.
Here is a working Plunker (besides the date counter)
It Should only be 38 days instead of 184.
//// Should Countdown till feb, 4th 2019 /////
let cd = new Countdown({
cont: document.querySelector(".container"),
endDate: 1549263600000,
outputTranslation: {
year: "Years",
week: "Weeks",
day: "Days",
hour: "Hours",
minute: "Minutes",
second: "Seconds"
},
endCallback: null,
outputFormat: "day|hour|minute|second"
});
Thank's I appreciate the help!
javascript datetime
asked 1 hour ago
BlunderCode
1
New contributor
BlunderCode is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
I have a semisimple pure js countdown clock that I am having trouble converting the millisecond time correctly.
Here is a working Plunker (besides the date counter)
It Should only be 38 days instead of 184.
//// Should Countdown till feb, 4th 2019 /////
let cd = new Countdown({
cont: document.querySelector(".container"),
endDate: 1549263600000,
outputTranslation: {
year: "Years",
week: "Weeks",
day: "Days",
hour: "Hours",
minute: "Minutes",
second: "Seconds"
},
endCallback: null,
outputFormat: "day|hour|minute|second"
});
Thank's I appreciate the help!
javascript datetime
asked 1 hour ago
BlunderCode
1
New contributor
BlunderCode is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
I have a semisimple pure js countdown clock that I am having trouble converting the millisecond time correctly.
Here is a working Plunker (besides the date counter)
It Should only be 38 days instead of 184.
//// Should Countdown till feb, 4th 2019 /////
let cd = new Countdown({
cont: document.querySelector(".container"),
endDate: 1549263600000,
outputTranslation: {
year: "Years",
week: "Weeks",
day: "Days",
hour: "Hours",
minute: "Minutes",
second: "Seconds"
},
endCallback: null,
outputFormat: "day|hour|minute|second"
});
Thank's I appreciate the help!
javascript datetime
asked 1 hour ago
BlunderCode
1
New contributor
BlunderCode is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
I have a semisimple pure js countdown clock that I am having trouble converting the millisecond time correctly.
Here is a working Plunker (besides the date counter)
It Should only be 38 days instead of 184.
//// Should Countdown till feb, 4th 2019 /////
let cd = new Countdown({
cont: document.querySelector(".container"),
endDate: 1549263600000,
outputTranslation: {
year: "Years",
week: "Weeks",
day: "Days",
hour: "Hours",
minute: "Minutes",
second: "Seconds"
},
endCallback: null,
outputFormat: "day|hour|minute|second"
});
Thank's I appreciate the help!
javascript datetime
javascript datetime
asked 1 hour ago
BlunderCode
1
New contributor
BlunderCode is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 1 hour ago
BlunderCode
1
New contributor
BlunderCode is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 1 hour ago
BlunderCode
1
New contributor
BlunderCode is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 1 hour ago
BlunderCode
1
asked 1 hour ago
BlunderCode
1
1
New contributor
BlunderCode is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
BlunderCode is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
BlunderCode is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
The plunker has this code at the top of the CountDown function:
let options = {
// ...
},
lastTick = null,
intervalsBySize = ["year", "week", "day", "hour", "minute", "second"],
TIMESTAMP_SECOND = 200,
TIMESTAMP_MINUTE = 60 * TIMESTAMP_SECOND,
TIMESTAMP_HOUR = 60 * TIMESTAMP_MINUTE,
TIMESTAMP_DAY = 24 * TIMESTAMP_HOUR,
TIMESTAMP_WEEK = 7 * TIMESTAMP_DAY,
TIMESTAMP_YEAR = 365 * TIMESTAMP_DAY,
elementClassPrefix = "countDown_",
interval = null,
digitConts = {};
... but that states that there are 200 milliseconds in a second. Obviously there are 1000 of them. So the line in question should be:
TIMESTAMP_SECOND = 1000,
This solves the issue. However, your setInterval also uses this variable for the length of the interval, and it might make sense to have more than one tick per second. So for that interval you should probably use a new variable that would indeed have the value 200.
Nice work though on the CSS side!
answered 26 mins ago
trincot
30126
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
BlunderCode is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210526%2fpure-js-countdown-clock-not-converting-millisecond-time-correctly%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
The plunker has this code at the top of the CountDown function:
let options = {
// ...
},
lastTick = null,
intervalsBySize = ["year", "week", "day", "hour", "minute", "second"],
TIMESTAMP_SECOND = 200,
TIMESTAMP_MINUTE = 60 * TIMESTAMP_SECOND,
TIMESTAMP_HOUR = 60 * TIMESTAMP_MINUTE,
TIMESTAMP_DAY = 24 * TIMESTAMP_HOUR,
TIMESTAMP_WEEK = 7 * TIMESTAMP_DAY,
TIMESTAMP_YEAR = 365 * TIMESTAMP_DAY,
elementClassPrefix = "countDown_",
interval = null,
digitConts = {};
... but that states that there are 200 milliseconds in a second. Obviously there are 1000 of them. So the line in question should be:
TIMESTAMP_SECOND = 1000,
This solves the issue. However, your setInterval also uses this variable for the length of the interval, and it might make sense to have more than one tick per second. So for that interval you should probably use a new variable that would indeed have the value 200.
Nice work though on the CSS side!
answered 26 mins ago
trincot
30126
add a comment |
The plunker has this code at the top of the CountDown function:
let options = {
// ...
},
lastTick = null,
intervalsBySize = ["year", "week", "day", "hour", "minute", "second"],
TIMESTAMP_SECOND = 200,
TIMESTAMP_MINUTE = 60 * TIMESTAMP_SECOND,
TIMESTAMP_HOUR = 60 * TIMESTAMP_MINUTE,
TIMESTAMP_DAY = 24 * TIMESTAMP_HOUR,
TIMESTAMP_WEEK = 7 * TIMESTAMP_DAY,
TIMESTAMP_YEAR = 365 * TIMESTAMP_DAY,
elementClassPrefix = "countDown_",
interval = null,
digitConts = {};
... but that states that there are 200 milliseconds in a second. Obviously there are 1000 of them. So the line in question should be:
TIMESTAMP_SECOND = 1000,
This solves the issue. However, your setInterval also uses this variable for the length of the interval, and it might make sense to have more than one tick per second. So for that interval you should probably use a new variable that would indeed have the value 200.
Nice work though on the CSS side!
answered 26 mins ago
trincot
30126
add a comment |
The plunker has this code at the top of the CountDown function:
let options = {
// ...
},
lastTick = null,
intervalsBySize = ["year", "week", "day", "hour", "minute", "second"],
TIMESTAMP_SECOND = 200,
TIMESTAMP_MINUTE = 60 * TIMESTAMP_SECOND,
TIMESTAMP_HOUR = 60 * TIMESTAMP_MINUTE,
TIMESTAMP_DAY = 24 * TIMESTAMP_HOUR,
TIMESTAMP_WEEK = 7 * TIMESTAMP_DAY,
TIMESTAMP_YEAR = 365 * TIMESTAMP_DAY,
elementClassPrefix = "countDown_",
interval = null,
digitConts = {};
... but that states that there are 200 milliseconds in a second. Obviously there are 1000 of them. So the line in question should be:
TIMESTAMP_SECOND = 1000,
This solves the issue. However, your setInterval also uses this variable for the length of the interval, and it might make sense to have more than one tick per second. So for that interval you should probably use a new variable that would indeed have the value 200.
Nice work though on the CSS side!
answered 26 mins ago
trincot
30126
The plunker has this code at the top of the CountDown function:
let options = {
// ...
},
lastTick = null,
intervalsBySize = ["year", "week", "day", "hour", "minute", "second"],
TIMESTAMP_SECOND = 200,
TIMESTAMP_MINUTE = 60 * TIMESTAMP_SECOND,
TIMESTAMP_HOUR = 60 * TIMESTAMP_MINUTE,
TIMESTAMP_DAY = 24 * TIMESTAMP_HOUR,
TIMESTAMP_WEEK = 7 * TIMESTAMP_DAY,
TIMESTAMP_YEAR = 365 * TIMESTAMP_DAY,
elementClassPrefix = "countDown_",
interval = null,
digitConts = {};
... but that states that there are 200 milliseconds in a second. Obviously there are 1000 of them. So the line in question should be:
TIMESTAMP_SECOND = 1000,
This solves the issue. However, your setInterval also uses this variable for the length of the interval, and it might make sense to have more than one tick per second. So for that interval you should probably use a new variable that would indeed have the value 200.
Nice work though on the CSS side!
answered 26 mins ago
trincot
30126
edited 20 mins ago
answered 26 mins ago
trincot
30126
answered 26 mins ago
trincot
30126
answered 26 mins ago
trincot
30126
30126
add a comment |
add a comment |
BlunderCode is a new contributor. Be nice, and check out our Code of Conduct.
BlunderCode is a new contributor. Be nice, and check out our Code of Conduct.
BlunderCode is a new contributor. Be nice, and check out our Code of Conduct.
BlunderCode is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210526%2fpure-js-countdown-clock-not-converting-millisecond-time-correctly%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
