Count characters of a text file
This program counts the number of the occurence of each character that is used in a file.
I tried to use everything that Java offers to me properly. If you have tips which library functions would have been better, how to make the code more readable, than let me know. If you have a tip how to improve the performance I would be very thankful, also if the readability would decrease than.
import java.util.Map;
import java.util.HashMap;
import java.io.File;
import java.io.FileReader;
import java.io.BufferedReader;
import java.io.IOException;
public class Main {
public static void main(String args) {
if (args[0].contains("help")) {
System.out.println("usage: java Main filename.txt");
}
Map<Character, Integer> map = new HashMap<>();
char chars = fileToCharList(args[0]);
for (int i = 0; i < chars.length; i++) {
if (map.containsKey(chars[i])) {
Integer number = map.get(chars[i]);
map.put(chars[i], ++number);
} else {
map.put(chars[i], 1);
}
}
for (Map.Entry<Character, Integer> entry : map.entrySet()) {
System.out.println(entry.getKey() + ": " + entry.
getValue());
}
}
private static char fileToCharList(String fileName) {
File file = new File(fileName);
StringBuilder sb = new StringBuilder();
try (BufferedReader br = new BufferedReader(new FileReader(
file))) {
String line;
while ((line = br.readLine()) != null) {
sb.append(line);
}
} catch (IOException e) {
e.printStackTrace();
}
return sb.toString().toCharArray();
}
}
java file
New contributor
add a comment |
This program counts the number of the occurence of each character that is used in a file.
I tried to use everything that Java offers to me properly. If you have tips which library functions would have been better, how to make the code more readable, than let me know. If you have a tip how to improve the performance I would be very thankful, also if the readability would decrease than.
import java.util.Map;
import java.util.HashMap;
import java.io.File;
import java.io.FileReader;
import java.io.BufferedReader;
import java.io.IOException;
public class Main {
public static void main(String args) {
if (args[0].contains("help")) {
System.out.println("usage: java Main filename.txt");
}
Map<Character, Integer> map = new HashMap<>();
char chars = fileToCharList(args[0]);
for (int i = 0; i < chars.length; i++) {
if (map.containsKey(chars[i])) {
Integer number = map.get(chars[i]);
map.put(chars[i], ++number);
} else {
map.put(chars[i], 1);
}
}
for (Map.Entry<Character, Integer> entry : map.entrySet()) {
System.out.println(entry.getKey() + ": " + entry.
getValue());
}
}
private static char fileToCharList(String fileName) {
File file = new File(fileName);
StringBuilder sb = new StringBuilder();
try (BufferedReader br = new BufferedReader(new FileReader(
file))) {
String line;
while ((line = br.readLine()) != null) {
sb.append(line);
}
} catch (IOException e) {
e.printStackTrace();
}
return sb.toString().toCharArray();
}
}
java file
New contributor
add a comment |
This program counts the number of the occurence of each character that is used in a file.
I tried to use everything that Java offers to me properly. If you have tips which library functions would have been better, how to make the code more readable, than let me know. If you have a tip how to improve the performance I would be very thankful, also if the readability would decrease than.
import java.util.Map;
import java.util.HashMap;
import java.io.File;
import java.io.FileReader;
import java.io.BufferedReader;
import java.io.IOException;
public class Main {
public static void main(String args) {
if (args[0].contains("help")) {
System.out.println("usage: java Main filename.txt");
}
Map<Character, Integer> map = new HashMap<>();
char chars = fileToCharList(args[0]);
for (int i = 0; i < chars.length; i++) {
if (map.containsKey(chars[i])) {
Integer number = map.get(chars[i]);
map.put(chars[i], ++number);
} else {
map.put(chars[i], 1);
}
}
for (Map.Entry<Character, Integer> entry : map.entrySet()) {
System.out.println(entry.getKey() + ": " + entry.
getValue());
}
}
private static char fileToCharList(String fileName) {
File file = new File(fileName);
StringBuilder sb = new StringBuilder();
try (BufferedReader br = new BufferedReader(new FileReader(
file))) {
String line;
while ((line = br.readLine()) != null) {
sb.append(line);
}
} catch (IOException e) {
e.printStackTrace();
}
return sb.toString().toCharArray();
}
}
java file
New contributor
This program counts the number of the occurence of each character that is used in a file.
I tried to use everything that Java offers to me properly. If you have tips which library functions would have been better, how to make the code more readable, than let me know. If you have a tip how to improve the performance I would be very thankful, also if the readability would decrease than.
import java.util.Map;
import java.util.HashMap;
import java.io.File;
import java.io.FileReader;
import java.io.BufferedReader;
import java.io.IOException;
public class Main {
public static void main(String args) {
if (args[0].contains("help")) {
System.out.println("usage: java Main filename.txt");
}
Map<Character, Integer> map = new HashMap<>();
char chars = fileToCharList(args[0]);
for (int i = 0; i < chars.length; i++) {
if (map.containsKey(chars[i])) {
Integer number = map.get(chars[i]);
map.put(chars[i], ++number);
} else {
map.put(chars[i], 1);
}
}
for (Map.Entry<Character, Integer> entry : map.entrySet()) {
System.out.println(entry.getKey() + ": " + entry.
getValue());
}
}
private static char fileToCharList(String fileName) {
File file = new File(fileName);
StringBuilder sb = new StringBuilder();
try (BufferedReader br = new BufferedReader(new FileReader(
file))) {
String line;
while ((line = br.readLine()) != null) {
sb.append(line);
}
} catch (IOException e) {
e.printStackTrace();
}
return sb.toString().toCharArray();
}
}
java file
java file
New contributor
New contributor
New contributor
asked 4 mins ago
Vengeancos
283
283
New contributor
New contributor
add a comment |
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Vengeancos is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210686%2fcount-characters-of-a-text-file%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Vengeancos is a new contributor. Be nice, and check out our Code of Conduct.
Vengeancos is a new contributor. Be nice, and check out our Code of Conduct.
Vengeancos is a new contributor. Be nice, and check out our Code of Conduct.
Vengeancos is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210686%2fcount-characters-of-a-text-file%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown