Reporting sums of shopping carts
up vote
1
down vote
favorite
I have an object (ShoppingCart
) that has a list of CartItem
s, which contains the related Product
and the quantity bought.
public class ShoppingCart extends BaseEntity {
@OneToMany(mappedBy = "shoppingCart", cascade = CascadeType.ALL, orphanRemoval = true)
private List<CartItem> cartItems = new ArrayList<>();
@DateTimeFormat(pattern = "dd/MM/yyyy hh:MM:ss")
private LocalDateTime dateTime;
@Enumerated
private PaymentMethod paymentMethod = PaymentMethod.CASH;
public class CartItem extends BaseEntity {
@ManyToOne
private Product product;
@ManyToOne(fetch = FetchType.LAZY)
@JoinColumn
private ShoppingCart shoppingCart;
public class Product extends BaseEntity {
@NotEmpty
private String name;
private double price;
private int quantity;
I have a view that sums all shopping carts, and I don't know if I should store that sum inside ShoppingCart
entity, or iterate to find the sum.
Here's the code, right now I'm iterating.
@GetMapping("/")
public String getProduct(@ModelAttribute("reportDto") ReportDto reportDto, Model model) {
double total = 0, cash = 0, credit = 0, debit = 0;
int quantity;
List<ShoppingCart> results;
if (reportDto.getBeginDate() == null || reportDto.getEndDate() == null) {
results = shoppingCartService.findAll();
} else {
results = shoppingCartService.findByDateTimeBetween(reportDto.getBeginDate(), reportDto.getEndDate());
}
total = results.stream()
.mapToDouble(shoppingCart -> shoppingCart.getCartItems().stream()
.mapToDouble(cartItem -> cartItem.getProduct().getPrice() * cartItem.getQuantity()).sum())
.sum();
quantity = results.stream().mapToInt(
shoppingCart -> shoppingCart.getCartItems().stream().mapToInt(cartItem -> cartItem.getQuantity()).sum())
.sum();
cash = results.stream().filter(shoppingCart -> shoppingCart.getPaymentMethod().isCash())
.mapToDouble(shoppingCart -> shoppingCart.getCartItems().stream()
.mapToDouble(cartItem -> cartItem.getProduct().getPrice() * cartItem.getQuantity()).sum())
.sum();
credit = results.stream().filter(shoppingCart -> shoppingCart.getPaymentMethod().isCredit())
.mapToDouble(shoppingCart -> shoppingCart.getCartItems().stream()
.mapToDouble(cartItem -> cartItem.getProduct().getPrice() * cartItem.getQuantity()).sum())
.sum();
debit = results.stream().filter(shoppingCart -> shoppingCart.getPaymentMethod().isDebit())
.mapToDouble(shoppingCart -> shoppingCart.getCartItems().stream()
.mapToDouble(cartItem -> cartItem.getProduct().getPrice() * cartItem.getQuantity()).sum())
.sum();
model.addAttribute("quantity", quantity);
model.addAttribute("cash", cash);
model.addAttribute("credit", credit);
model.addAttribute("debit", debit);
model.addAttribute("total", total);
return "reports/reports";
}
Also, any feedback regarding the code will be appreciated!
java spring e-commerce spring-mvc
New contributor
add a comment |
up vote
1
down vote
favorite
I have an object (ShoppingCart
) that has a list of CartItem
s, which contains the related Product
and the quantity bought.
public class ShoppingCart extends BaseEntity {
@OneToMany(mappedBy = "shoppingCart", cascade = CascadeType.ALL, orphanRemoval = true)
private List<CartItem> cartItems = new ArrayList<>();
@DateTimeFormat(pattern = "dd/MM/yyyy hh:MM:ss")
private LocalDateTime dateTime;
@Enumerated
private PaymentMethod paymentMethod = PaymentMethod.CASH;
public class CartItem extends BaseEntity {
@ManyToOne
private Product product;
@ManyToOne(fetch = FetchType.LAZY)
@JoinColumn
private ShoppingCart shoppingCart;
public class Product extends BaseEntity {
@NotEmpty
private String name;
private double price;
private int quantity;
I have a view that sums all shopping carts, and I don't know if I should store that sum inside ShoppingCart
entity, or iterate to find the sum.
Here's the code, right now I'm iterating.
@GetMapping("/")
public String getProduct(@ModelAttribute("reportDto") ReportDto reportDto, Model model) {
double total = 0, cash = 0, credit = 0, debit = 0;
int quantity;
List<ShoppingCart> results;
if (reportDto.getBeginDate() == null || reportDto.getEndDate() == null) {
results = shoppingCartService.findAll();
} else {
results = shoppingCartService.findByDateTimeBetween(reportDto.getBeginDate(), reportDto.getEndDate());
}
total = results.stream()
.mapToDouble(shoppingCart -> shoppingCart.getCartItems().stream()
.mapToDouble(cartItem -> cartItem.getProduct().getPrice() * cartItem.getQuantity()).sum())
.sum();
quantity = results.stream().mapToInt(
shoppingCart -> shoppingCart.getCartItems().stream().mapToInt(cartItem -> cartItem.getQuantity()).sum())
.sum();
cash = results.stream().filter(shoppingCart -> shoppingCart.getPaymentMethod().isCash())
.mapToDouble(shoppingCart -> shoppingCart.getCartItems().stream()
.mapToDouble(cartItem -> cartItem.getProduct().getPrice() * cartItem.getQuantity()).sum())
.sum();
credit = results.stream().filter(shoppingCart -> shoppingCart.getPaymentMethod().isCredit())
.mapToDouble(shoppingCart -> shoppingCart.getCartItems().stream()
.mapToDouble(cartItem -> cartItem.getProduct().getPrice() * cartItem.getQuantity()).sum())
.sum();
debit = results.stream().filter(shoppingCart -> shoppingCart.getPaymentMethod().isDebit())
.mapToDouble(shoppingCart -> shoppingCart.getCartItems().stream()
.mapToDouble(cartItem -> cartItem.getProduct().getPrice() * cartItem.getQuantity()).sum())
.sum();
model.addAttribute("quantity", quantity);
model.addAttribute("cash", cash);
model.addAttribute("credit", credit);
model.addAttribute("debit", debit);
model.addAttribute("total", total);
return "reports/reports";
}
Also, any feedback regarding the code will be appreciated!
java spring e-commerce spring-mvc
New contributor
add a comment |
up vote
1
down vote
favorite
up vote
1
down vote
favorite
I have an object (ShoppingCart
) that has a list of CartItem
s, which contains the related Product
and the quantity bought.
public class ShoppingCart extends BaseEntity {
@OneToMany(mappedBy = "shoppingCart", cascade = CascadeType.ALL, orphanRemoval = true)
private List<CartItem> cartItems = new ArrayList<>();
@DateTimeFormat(pattern = "dd/MM/yyyy hh:MM:ss")
private LocalDateTime dateTime;
@Enumerated
private PaymentMethod paymentMethod = PaymentMethod.CASH;
public class CartItem extends BaseEntity {
@ManyToOne
private Product product;
@ManyToOne(fetch = FetchType.LAZY)
@JoinColumn
private ShoppingCart shoppingCart;
public class Product extends BaseEntity {
@NotEmpty
private String name;
private double price;
private int quantity;
I have a view that sums all shopping carts, and I don't know if I should store that sum inside ShoppingCart
entity, or iterate to find the sum.
Here's the code, right now I'm iterating.
@GetMapping("/")
public String getProduct(@ModelAttribute("reportDto") ReportDto reportDto, Model model) {
double total = 0, cash = 0, credit = 0, debit = 0;
int quantity;
List<ShoppingCart> results;
if (reportDto.getBeginDate() == null || reportDto.getEndDate() == null) {
results = shoppingCartService.findAll();
} else {
results = shoppingCartService.findByDateTimeBetween(reportDto.getBeginDate(), reportDto.getEndDate());
}
total = results.stream()
.mapToDouble(shoppingCart -> shoppingCart.getCartItems().stream()
.mapToDouble(cartItem -> cartItem.getProduct().getPrice() * cartItem.getQuantity()).sum())
.sum();
quantity = results.stream().mapToInt(
shoppingCart -> shoppingCart.getCartItems().stream().mapToInt(cartItem -> cartItem.getQuantity()).sum())
.sum();
cash = results.stream().filter(shoppingCart -> shoppingCart.getPaymentMethod().isCash())
.mapToDouble(shoppingCart -> shoppingCart.getCartItems().stream()
.mapToDouble(cartItem -> cartItem.getProduct().getPrice() * cartItem.getQuantity()).sum())
.sum();
credit = results.stream().filter(shoppingCart -> shoppingCart.getPaymentMethod().isCredit())
.mapToDouble(shoppingCart -> shoppingCart.getCartItems().stream()
.mapToDouble(cartItem -> cartItem.getProduct().getPrice() * cartItem.getQuantity()).sum())
.sum();
debit = results.stream().filter(shoppingCart -> shoppingCart.getPaymentMethod().isDebit())
.mapToDouble(shoppingCart -> shoppingCart.getCartItems().stream()
.mapToDouble(cartItem -> cartItem.getProduct().getPrice() * cartItem.getQuantity()).sum())
.sum();
model.addAttribute("quantity", quantity);
model.addAttribute("cash", cash);
model.addAttribute("credit", credit);
model.addAttribute("debit", debit);
model.addAttribute("total", total);
return "reports/reports";
}
Also, any feedback regarding the code will be appreciated!
java spring e-commerce spring-mvc
New contributor
I have an object (ShoppingCart
) that has a list of CartItem
s, which contains the related Product
and the quantity bought.
public class ShoppingCart extends BaseEntity {
@OneToMany(mappedBy = "shoppingCart", cascade = CascadeType.ALL, orphanRemoval = true)
private List<CartItem> cartItems = new ArrayList<>();
@DateTimeFormat(pattern = "dd/MM/yyyy hh:MM:ss")
private LocalDateTime dateTime;
@Enumerated
private PaymentMethod paymentMethod = PaymentMethod.CASH;
public class CartItem extends BaseEntity {
@ManyToOne
private Product product;
@ManyToOne(fetch = FetchType.LAZY)
@JoinColumn
private ShoppingCart shoppingCart;
public class Product extends BaseEntity {
@NotEmpty
private String name;
private double price;
private int quantity;
I have a view that sums all shopping carts, and I don't know if I should store that sum inside ShoppingCart
entity, or iterate to find the sum.
Here's the code, right now I'm iterating.
@GetMapping("/")
public String getProduct(@ModelAttribute("reportDto") ReportDto reportDto, Model model) {
double total = 0, cash = 0, credit = 0, debit = 0;
int quantity;
List<ShoppingCart> results;
if (reportDto.getBeginDate() == null || reportDto.getEndDate() == null) {
results = shoppingCartService.findAll();
} else {
results = shoppingCartService.findByDateTimeBetween(reportDto.getBeginDate(), reportDto.getEndDate());
}
total = results.stream()
.mapToDouble(shoppingCart -> shoppingCart.getCartItems().stream()
.mapToDouble(cartItem -> cartItem.getProduct().getPrice() * cartItem.getQuantity()).sum())
.sum();
quantity = results.stream().mapToInt(
shoppingCart -> shoppingCart.getCartItems().stream().mapToInt(cartItem -> cartItem.getQuantity()).sum())
.sum();
cash = results.stream().filter(shoppingCart -> shoppingCart.getPaymentMethod().isCash())
.mapToDouble(shoppingCart -> shoppingCart.getCartItems().stream()
.mapToDouble(cartItem -> cartItem.getProduct().getPrice() * cartItem.getQuantity()).sum())
.sum();
credit = results.stream().filter(shoppingCart -> shoppingCart.getPaymentMethod().isCredit())
.mapToDouble(shoppingCart -> shoppingCart.getCartItems().stream()
.mapToDouble(cartItem -> cartItem.getProduct().getPrice() * cartItem.getQuantity()).sum())
.sum();
debit = results.stream().filter(shoppingCart -> shoppingCart.getPaymentMethod().isDebit())
.mapToDouble(shoppingCart -> shoppingCart.getCartItems().stream()
.mapToDouble(cartItem -> cartItem.getProduct().getPrice() * cartItem.getQuantity()).sum())
.sum();
model.addAttribute("quantity", quantity);
model.addAttribute("cash", cash);
model.addAttribute("credit", credit);
model.addAttribute("debit", debit);
model.addAttribute("total", total);
return "reports/reports";
}
Also, any feedback regarding the code will be appreciated!
java spring e-commerce spring-mvc
java spring e-commerce spring-mvc
New contributor
New contributor
edited 15 mins ago
200_success
128k15149412
128k15149412
New contributor
asked 13 hours ago
fsakiyama
61
61
New contributor
New contributor
add a comment |
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
fsakiyama is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209984%2freporting-sums-of-shopping-carts%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
fsakiyama is a new contributor. Be nice, and check out our Code of Conduct.
fsakiyama is a new contributor. Be nice, and check out our Code of Conduct.
fsakiyama is a new contributor. Be nice, and check out our Code of Conduct.
fsakiyama is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209984%2freporting-sums-of-shopping-carts%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown