Unquoting booleans, numbers, etc. in a JSON string
I have a method that takes a JSON string as input and "fixes" it. By that, I mean, that the JSON string comes in with all values quoted. My method un-quotes the values that shouldn't be quoted (i.e. true, false, numbers, {}, etc). The method was originally doing it by doing 4 string replaces (for the true / false, etc) and regex replace for the numbers. Kind of slow. So I re-wrote it with StringBuilder:
protected static string FixupJson(string json)
{
if (json == null)
throw new ArgumentNullException(nameof(json));
int nLen = json.Length;
StringBuilder sb = new StringBuilder(nLen);
for (int i = 0; i < nLen; i++)
{
char ch = json[i];
if (ch == ':' && json[i+1] == ' ' && json[i + 2] == '"')
{
int k = json.IndexOf('"', i + 3);
sb.Append(": ");
string g = json.Substring(i + 3, k - i - 3);
bool bQuote = true;
if (g == "true" || g == "false" || g == "null" || g == "{}")
bQuote = false;
else if (g == "NaN")
bQuote = true;
else if (Double.TryParse(g, out double d))
bQuote = false;
if (bQuote)
sb.Append('"');
sb.Append(g);
if (bQuote)
sb.Append('"');
i = k;
}
else
{
sb.Append(ch);
}
}
return sb.ToString();
}
This got me a 35% improvement, but I want to see if there is a better approach or if I can get this faster. My first StringBuilder approach, instead of appending char by char would append chunks pulled out with SubString(). That was actually a lot slower then this version.
Yes, I understand the right way to do it would be to fix it at the source :), which I do control, but the way the json gets serialized out at the source, I don't know if the value needs to be quoted until the json is fully spit out (or at least until the value is fully spit out) as a single value can be a formatted string from multiple sources (i.e. "myVal": "(this part from one place)|(this part from another place))". So "fixing it there" would mean going from a single String.Format() for the entire json to a bunch of them for each value. Right now the JSON is "pre-rendered" (once) and passed into a String.Format() to fill in the values, so by fixing it there I'd have to go to a bunch of little String.Format()'s to format each value then pass it in to the big String.Format()… so I figure this is a decent compromise.
c# performance json escaping
edited 9 mins ago
200_success
128k15151413
asked 46 mins ago
SledgeHammer
1061
New contributor
SledgeHammer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
I have a method that takes a JSON string as input and "fixes" it. By that, I mean, that the JSON string comes in with all values quoted. My method un-quotes the values that shouldn't be quoted (i.e. true, false, numbers, {}, etc). The method was originally doing it by doing 4 string replaces (for the true / false, etc) and regex replace for the numbers. Kind of slow. So I re-wrote it with StringBuilder:
protected static string FixupJson(string json)
{
if (json == null)
throw new ArgumentNullException(nameof(json));
int nLen = json.Length;
StringBuilder sb = new StringBuilder(nLen);
for (int i = 0; i < nLen; i++)
{
char ch = json[i];
if (ch == ':' && json[i+1] == ' ' && json[i + 2] == '"')
{
int k = json.IndexOf('"', i + 3);
sb.Append(": ");
string g = json.Substring(i + 3, k - i - 3);
bool bQuote = true;
if (g == "true" || g == "false" || g == "null" || g == "{}")
bQuote = false;
else if (g == "NaN")
bQuote = true;
else if (Double.TryParse(g, out double d))
bQuote = false;
if (bQuote)
sb.Append('"');
sb.Append(g);
if (bQuote)
sb.Append('"');
i = k;
}
else
{
sb.Append(ch);
}
}
return sb.ToString();
}
This got me a 35% improvement, but I want to see if there is a better approach or if I can get this faster. My first StringBuilder approach, instead of appending char by char would append chunks pulled out with SubString(). That was actually a lot slower then this version.
Yes, I understand the right way to do it would be to fix it at the source :), which I do control, but the way the json gets serialized out at the source, I don't know if the value needs to be quoted until the json is fully spit out (or at least until the value is fully spit out) as a single value can be a formatted string from multiple sources (i.e. "myVal": "(this part from one place)|(this part from another place))". So "fixing it there" would mean going from a single String.Format() for the entire json to a bunch of them for each value. Right now the JSON is "pre-rendered" (once) and passed into a String.Format() to fill in the values, so by fixing it there I'd have to go to a bunch of little String.Format()'s to format each value then pass it in to the big String.Format()… so I figure this is a decent compromise.
c# performance json escaping
edited 9 mins ago
200_success
128k15151413
asked 46 mins ago
SledgeHammer
1061
New contributor
SledgeHammer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
What would the typical json string look like? What does the format method look like? More eyes on it might see an even better solution.
– tinstaafl
3 mins ago
add a comment |
I have a method that takes a JSON string as input and "fixes" it. By that, I mean, that the JSON string comes in with all values quoted. My method un-quotes the values that shouldn't be quoted (i.e. true, false, numbers, {}, etc). The method was originally doing it by doing 4 string replaces (for the true / false, etc) and regex replace for the numbers. Kind of slow. So I re-wrote it with StringBuilder:
protected static string FixupJson(string json)
{
if (json == null)
throw new ArgumentNullException(nameof(json));
int nLen = json.Length;
StringBuilder sb = new StringBuilder(nLen);
for (int i = 0; i < nLen; i++)
{
char ch = json[i];
if (ch == ':' && json[i+1] == ' ' && json[i + 2] == '"')
{
int k = json.IndexOf('"', i + 3);
sb.Append(": ");
string g = json.Substring(i + 3, k - i - 3);
bool bQuote = true;
if (g == "true" || g == "false" || g == "null" || g == "{}")
bQuote = false;
else if (g == "NaN")
bQuote = true;
else if (Double.TryParse(g, out double d))
bQuote = false;
if (bQuote)
sb.Append('"');
sb.Append(g);
if (bQuote)
sb.Append('"');
i = k;
}
else
{
sb.Append(ch);
}
}
return sb.ToString();
}
This got me a 35% improvement, but I want to see if there is a better approach or if I can get this faster. My first StringBuilder approach, instead of appending char by char would append chunks pulled out with SubString(). That was actually a lot slower then this version.
Yes, I understand the right way to do it would be to fix it at the source :), which I do control, but the way the json gets serialized out at the source, I don't know if the value needs to be quoted until the json is fully spit out (or at least until the value is fully spit out) as a single value can be a formatted string from multiple sources (i.e. "myVal": "(this part from one place)|(this part from another place))". So "fixing it there" would mean going from a single String.Format() for the entire json to a bunch of them for each value. Right now the JSON is "pre-rendered" (once) and passed into a String.Format() to fill in the values, so by fixing it there I'd have to go to a bunch of little String.Format()'s to format each value then pass it in to the big String.Format()… so I figure this is a decent compromise.
c# performance json escaping
edited 9 mins ago
200_success
128k15151413
asked 46 mins ago
SledgeHammer
1061
New contributor
SledgeHammer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
I have a method that takes a JSON string as input and "fixes" it. By that, I mean, that the JSON string comes in with all values quoted. My method un-quotes the values that shouldn't be quoted (i.e. true, false, numbers, {}, etc). The method was originally doing it by doing 4 string replaces (for the true / false, etc) and regex replace for the numbers. Kind of slow. So I re-wrote it with StringBuilder:
protected static string FixupJson(string json)
{
if (json == null)
throw new ArgumentNullException(nameof(json));
int nLen = json.Length;
StringBuilder sb = new StringBuilder(nLen);
for (int i = 0; i < nLen; i++)
{
char ch = json[i];
if (ch == ':' && json[i+1] == ' ' && json[i + 2] == '"')
{
int k = json.IndexOf('"', i + 3);
sb.Append(": ");
string g = json.Substring(i + 3, k - i - 3);
bool bQuote = true;
if (g == "true" || g == "false" || g == "null" || g == "{}")
bQuote = false;
else if (g == "NaN")
bQuote = true;
else if (Double.TryParse(g, out double d))
bQuote = false;
if (bQuote)
sb.Append('"');
sb.Append(g);
if (bQuote)
sb.Append('"');
i = k;
}
else
{
sb.Append(ch);
}
}
return sb.ToString();
}
This got me a 35% improvement, but I want to see if there is a better approach or if I can get this faster. My first StringBuilder approach, instead of appending char by char would append chunks pulled out with SubString(). That was actually a lot slower then this version.
Yes, I understand the right way to do it would be to fix it at the source :), which I do control, but the way the json gets serialized out at the source, I don't know if the value needs to be quoted until the json is fully spit out (or at least until the value is fully spit out) as a single value can be a formatted string from multiple sources (i.e. "myVal": "(this part from one place)|(this part from another place))". So "fixing it there" would mean going from a single String.Format() for the entire json to a bunch of them for each value. Right now the JSON is "pre-rendered" (once) and passed into a String.Format() to fill in the values, so by fixing it there I'd have to go to a bunch of little String.Format()'s to format each value then pass it in to the big String.Format()… so I figure this is a decent compromise.
c# performance json escaping
c# performance json escaping
edited 9 mins ago
200_success
128k15151413
asked 46 mins ago
SledgeHammer
1061
New contributor
SledgeHammer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 9 mins ago
200_success
128k15151413
asked 46 mins ago
SledgeHammer
1061
New contributor
SledgeHammer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 9 mins ago
200_success
128k15151413
edited 9 mins ago
200_success
128k15151413
edited 9 mins ago
200_success
128k15151413
128k15151413
asked 46 mins ago
SledgeHammer
1061
New contributor
SledgeHammer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 46 mins ago
SledgeHammer
1061
asked 46 mins ago
SledgeHammer
1061
1061
New contributor
SledgeHammer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
SledgeHammer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
SledgeHammer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
What would the typical json string look like? What does the format method look like? More eyes on it might see an even better solution.
– tinstaafl
3 mins ago
add a comment |
What would the typical json string look like? What does the format method look like? More eyes on it might see an even better solution.
– tinstaafl
3 mins ago
What would the typical json string look like? What does the format method look like? More eyes on it might see an even better solution.
– tinstaafl
3 mins ago
What would the typical json string look like? What does the format method look like? More eyes on it might see an even better solution.
– tinstaafl
3 mins ago
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
SledgeHammer is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210716%2funquoting-booleans-numbers-etc-in-a-json-string%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
SledgeHammer is a new contributor. Be nice, and check out our Code of Conduct.
SledgeHammer is a new contributor. Be nice, and check out our Code of Conduct.
SledgeHammer is a new contributor. Be nice, and check out our Code of Conduct.
SledgeHammer is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210716%2funquoting-booleans-numbers-etc-in-a-json-string%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
What would the typical json string look like? What does the format method look like? More eyes on it might see an even better solution.
– tinstaafl
3 mins ago