Fetching data from API in JavaScript
up vote
3
down vote
favorite
I'm using Axios to fetch data from an API, and don't know if this is the best way to deal with APIs in ReactJS or not. I want to know if anyone can suggest edits or something to make the code more efficient.
api.js
import axios from 'axios';
export const APIendpoint = axios.create({
baseURL: 'https://1eb19101-0790-406f-90e0-ee35a2ff2d1f.mock.pstmn.io',
timeout: 2000
});
matchesAction.js
import {FETCH_MATCHES} from './actionTypes';
import {APIendpoint} from '../api/api';
export const fetchMatches = () => dispatch => {
const matchInstance = APIendpoint.get('/matches');
matchInstance.then(response =>
dispatch({
type: FETCH_MATCHES,
payload: response.data
})
);
};
javascript react.js axios
asked Jul 11 at 19:20
gretty volk
162
bumped to the homepage by Community♦ 11 hours ago
This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.
add a comment |
up vote
3
down vote
favorite
I'm using Axios to fetch data from an API, and don't know if this is the best way to deal with APIs in ReactJS or not. I want to know if anyone can suggest edits or something to make the code more efficient.
api.js
import axios from 'axios';
export const APIendpoint = axios.create({
baseURL: 'https://1eb19101-0790-406f-90e0-ee35a2ff2d1f.mock.pstmn.io',
timeout: 2000
});
matchesAction.js
import {FETCH_MATCHES} from './actionTypes';
import {APIendpoint} from '../api/api';
export const fetchMatches = () => dispatch => {
const matchInstance = APIendpoint.get('/matches');
matchInstance.then(response =>
dispatch({
type: FETCH_MATCHES,
payload: response.data
})
);
};
javascript react.js axios
asked Jul 11 at 19:20
gretty volk
162
bumped to the homepage by Community♦ 11 hours ago
This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.
add a comment |
up vote
3
down vote
favorite
up vote
3
down vote
favorite
I'm using Axios to fetch data from an API, and don't know if this is the best way to deal with APIs in ReactJS or not. I want to know if anyone can suggest edits or something to make the code more efficient.
api.js
import axios from 'axios';
export const APIendpoint = axios.create({
baseURL: 'https://1eb19101-0790-406f-90e0-ee35a2ff2d1f.mock.pstmn.io',
timeout: 2000
});
matchesAction.js
import {FETCH_MATCHES} from './actionTypes';
import {APIendpoint} from '../api/api';
export const fetchMatches = () => dispatch => {
const matchInstance = APIendpoint.get('/matches');
matchInstance.then(response =>
dispatch({
type: FETCH_MATCHES,
payload: response.data
})
);
};
javascript react.js axios
asked Jul 11 at 19:20
gretty volk
162
I'm using Axios to fetch data from an API, and don't know if this is the best way to deal with APIs in ReactJS or not. I want to know if anyone can suggest edits or something to make the code more efficient.
api.js
import axios from 'axios';
export const APIendpoint = axios.create({
baseURL: 'https://1eb19101-0790-406f-90e0-ee35a2ff2d1f.mock.pstmn.io',
timeout: 2000
});
matchesAction.js
import {FETCH_MATCHES} from './actionTypes';
import {APIendpoint} from '../api/api';
export const fetchMatches = () => dispatch => {
const matchInstance = APIendpoint.get('/matches');
matchInstance.then(response =>
dispatch({
type: FETCH_MATCHES,
payload: response.data
})
);
};
javascript react.js axios
javascript react.js axios
asked Jul 11 at 19:20
gretty volk
162
asked Jul 11 at 19:20
gretty volk
162
edited Jul 11 at 19:28
asked Jul 11 at 19:20
gretty volk
162
asked Jul 11 at 19:20
gretty volk
162
asked Jul 11 at 19:20
gretty volk
162
162
bumped to the homepage by Community♦ 11 hours ago
This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.
bumped to the homepage by Community♦ 11 hours ago
This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
up vote
0
down vote
It can be done in many ways based on your use case & code structure, but i feel this can be optimal way of structuring.
api/services/index.js
import axios from 'axios';
export {default as MATCHES_API} from "./services/matches.js";
export const CONFIG_API = axios.create({
baseURL: 'https://1eb19101-0790-406f-90e0-ee35a2ff2d1f.mock.pstmn.io',
timeout: 2000
});
api/services/matches.js
import CONFIG_API from "api/services";
const ERROR_MSG = "<generic message>";
export const matches = () => {
return CONFIG_API.get("/matches").then(res => {
// do some operations on data - if required
return {success: true, data: res.payload};
}).catch(err => {
return {success: false, message: ERROR_MSG || err.message};
});
};
actions/matchesAction.js
import {FETCH_MATCHES} from './actionTypes';
import {MATCHES_API} from "/api/services";
export const fetchMatches = () => dispatch => {
matches.then((response) =>
const {success} = response;
if (success) {
dispatch({ type: FETCH_MATCHES, payload});
} else {
dispatch({ type: FETCH_MATCHES_FAILED}); /* or show notification */ .
}
);
};
Let me know if this works out.
answered Jul 15 at 14:49
Sandeep kumar H R
243
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f198311%2ffetching-data-from-api-in-javascript%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
up vote
0
down vote
It can be done in many ways based on your use case & code structure, but i feel this can be optimal way of structuring.
api/services/index.js
import axios from 'axios';
export {default as MATCHES_API} from "./services/matches.js";
export const CONFIG_API = axios.create({
baseURL: 'https://1eb19101-0790-406f-90e0-ee35a2ff2d1f.mock.pstmn.io',
timeout: 2000
});
api/services/matches.js
import CONFIG_API from "api/services";
const ERROR_MSG = "<generic message>";
export const matches = () => {
return CONFIG_API.get("/matches").then(res => {
// do some operations on data - if required
return {success: true, data: res.payload};
}).catch(err => {
return {success: false, message: ERROR_MSG || err.message};
});
};
actions/matchesAction.js
import {FETCH_MATCHES} from './actionTypes';
import {MATCHES_API} from "/api/services";
export const fetchMatches = () => dispatch => {
matches.then((response) =>
const {success} = response;
if (success) {
dispatch({ type: FETCH_MATCHES, payload});
} else {
dispatch({ type: FETCH_MATCHES_FAILED}); /* or show notification */ .
}
);
};
Let me know if this works out.
answered Jul 15 at 14:49
Sandeep kumar H R
243
add a comment |
up vote
0
down vote
It can be done in many ways based on your use case & code structure, but i feel this can be optimal way of structuring.
api/services/index.js
import axios from 'axios';
export {default as MATCHES_API} from "./services/matches.js";
export const CONFIG_API = axios.create({
baseURL: 'https://1eb19101-0790-406f-90e0-ee35a2ff2d1f.mock.pstmn.io',
timeout: 2000
});
api/services/matches.js
import CONFIG_API from "api/services";
const ERROR_MSG = "<generic message>";
export const matches = () => {
return CONFIG_API.get("/matches").then(res => {
// do some operations on data - if required
return {success: true, data: res.payload};
}).catch(err => {
return {success: false, message: ERROR_MSG || err.message};
});
};
actions/matchesAction.js
import {FETCH_MATCHES} from './actionTypes';
import {MATCHES_API} from "/api/services";
export const fetchMatches = () => dispatch => {
matches.then((response) =>
const {success} = response;
if (success) {
dispatch({ type: FETCH_MATCHES, payload});
} else {
dispatch({ type: FETCH_MATCHES_FAILED}); /* or show notification */ .
}
);
};
Let me know if this works out.
answered Jul 15 at 14:49
Sandeep kumar H R
243
add a comment |
up vote
0
down vote
up vote
0
down vote
It can be done in many ways based on your use case & code structure, but i feel this can be optimal way of structuring.
api/services/index.js
import axios from 'axios';
export {default as MATCHES_API} from "./services/matches.js";
export const CONFIG_API = axios.create({
baseURL: 'https://1eb19101-0790-406f-90e0-ee35a2ff2d1f.mock.pstmn.io',
timeout: 2000
});
api/services/matches.js
import CONFIG_API from "api/services";
const ERROR_MSG = "<generic message>";
export const matches = () => {
return CONFIG_API.get("/matches").then(res => {
// do some operations on data - if required
return {success: true, data: res.payload};
}).catch(err => {
return {success: false, message: ERROR_MSG || err.message};
});
};
actions/matchesAction.js
import {FETCH_MATCHES} from './actionTypes';
import {MATCHES_API} from "/api/services";
export const fetchMatches = () => dispatch => {
matches.then((response) =>
const {success} = response;
if (success) {
dispatch({ type: FETCH_MATCHES, payload});
} else {
dispatch({ type: FETCH_MATCHES_FAILED}); /* or show notification */ .
}
);
};
Let me know if this works out.
answered Jul 15 at 14:49
Sandeep kumar H R
243
It can be done in many ways based on your use case & code structure, but i feel this can be optimal way of structuring.
api/services/index.js
import axios from 'axios';
export {default as MATCHES_API} from "./services/matches.js";
export const CONFIG_API = axios.create({
baseURL: 'https://1eb19101-0790-406f-90e0-ee35a2ff2d1f.mock.pstmn.io',
timeout: 2000
});
api/services/matches.js
import CONFIG_API from "api/services";
const ERROR_MSG = "<generic message>";
export const matches = () => {
return CONFIG_API.get("/matches").then(res => {
// do some operations on data - if required
return {success: true, data: res.payload};
}).catch(err => {
return {success: false, message: ERROR_MSG || err.message};
});
};
actions/matchesAction.js
import {FETCH_MATCHES} from './actionTypes';
import {MATCHES_API} from "/api/services";
export const fetchMatches = () => dispatch => {
matches.then((response) =>
const {success} = response;
if (success) {
dispatch({ type: FETCH_MATCHES, payload});
} else {
dispatch({ type: FETCH_MATCHES_FAILED}); /* or show notification */ .
}
);
};
Let me know if this works out.
answered Jul 15 at 14:49
Sandeep kumar H R
243
answered Jul 15 at 14:49
Sandeep kumar H R
243
answered Jul 15 at 14:49
Sandeep kumar H R
243
answered Jul 15 at 14:49
Sandeep kumar H R
243
243
add a comment |
add a comment |
draft saved
draft discarded
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f198311%2ffetching-data-from-api-in-javascript%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
