WaitForSingleObject with windows messages processing
1
Is this reliable, or have I missed something?
I want a drop-in replacement for WaitForSingleObject (sans the return type, I like HRESULT much better than any other error codes).
This code works in a plugin DLL for third party closed-source software. I don’t have source code of that app, i.e. if you ask “what else might happen on the same thread while it waits?” the answer is “anything at all”.
constexpr HRESULT E_TIMEOUT = HRESULT_FROM_WIN32( ERROR_TIMEOUT );
constexpr int MSGF_SLEEPMSG = 0x5300;
inline HRESULT getLastHr() { return HRESULT_FROM_WIN32( GetLastError() ); }
// Same as WaitForSingleObject but processes windows messages while it waits.
HRESULT msgWaitForSingleObject( HANDLE h, DWORD ms )
{
// https://blogs.msdn.microsoft.com/oldnewthing/20060126-00/?p=32513/
while( true )
{
const DWORD started = GetTickCount();
const DWORD res = MsgWaitForMultipleObjectsEx( 1, &h, ms, QS_ALLINPUT, MWMO_INPUTAVAILABLE );
if( WAIT_OBJECT_0 == res )
return S_OK;
if( WAIT_OBJECT_0 + 1 == res )
{
MSG msg;
while( PeekMessage( &msg, NULL, 0, 0, PM_REMOVE ) )
{
if( msg.message == WM_QUIT )
{
PostQuitMessage( (int)msg.wParam );
return S_FALSE; // Abandoned due to WM_QUIT
}
if( !CallMsgFilter( &msg, MSGF_SLEEPMSG ) )
{
TranslateMessage( &msg );
DispatchMessage( &msg );
}
}
const DWORD elapsed = GetTickCount() - started; //< This works OK even when DWORD overflows: https://codereview.stackexchange.com/a/129670/46194
if( elapsed > ms )
return E_TIMEOUT;
ms -= elapsed;
continue;
}
if( WAIT_TIMEOUT == res )
return E_TIMEOUT;
HRESULT hr = getLastHr();
if( FAILED( hr ) )
return hr;
return E_UNEXPECTED; // Unasked IO_COMPLETION or ABANDONED?
}
}
c++ winapi
asked 12 mins ago
Soonts
1534
add a comment |
1
Is this reliable, or have I missed something?
I want a drop-in replacement for WaitForSingleObject (sans the return type, I like HRESULT much better than any other error codes).
This code works in a plugin DLL for third party closed-source software. I don’t have source code of that app, i.e. if you ask “what else might happen on the same thread while it waits?” the answer is “anything at all”.
constexpr HRESULT E_TIMEOUT = HRESULT_FROM_WIN32( ERROR_TIMEOUT );
constexpr int MSGF_SLEEPMSG = 0x5300;
inline HRESULT getLastHr() { return HRESULT_FROM_WIN32( GetLastError() ); }
// Same as WaitForSingleObject but processes windows messages while it waits.
HRESULT msgWaitForSingleObject( HANDLE h, DWORD ms )
{
// https://blogs.msdn.microsoft.com/oldnewthing/20060126-00/?p=32513/
while( true )
{
const DWORD started = GetTickCount();
const DWORD res = MsgWaitForMultipleObjectsEx( 1, &h, ms, QS_ALLINPUT, MWMO_INPUTAVAILABLE );
if( WAIT_OBJECT_0 == res )
return S_OK;
if( WAIT_OBJECT_0 + 1 == res )
{
MSG msg;
while( PeekMessage( &msg, NULL, 0, 0, PM_REMOVE ) )
{
if( msg.message == WM_QUIT )
{
PostQuitMessage( (int)msg.wParam );
return S_FALSE; // Abandoned due to WM_QUIT
}
if( !CallMsgFilter( &msg, MSGF_SLEEPMSG ) )
{
TranslateMessage( &msg );
DispatchMessage( &msg );
}
}
const DWORD elapsed = GetTickCount() - started; //< This works OK even when DWORD overflows: https://codereview.stackexchange.com/a/129670/46194
if( elapsed > ms )
return E_TIMEOUT;
ms -= elapsed;
continue;
}
if( WAIT_TIMEOUT == res )
return E_TIMEOUT;
HRESULT hr = getLastHr();
if( FAILED( hr ) )
return hr;
return E_UNEXPECTED; // Unasked IO_COMPLETION or ABANDONED?
}
}
c++ winapi
asked 12 mins ago
Soonts
1534
add a comment |
1
1
1
Is this reliable, or have I missed something?
I want a drop-in replacement for WaitForSingleObject (sans the return type, I like HRESULT much better than any other error codes).
This code works in a plugin DLL for third party closed-source software. I don’t have source code of that app, i.e. if you ask “what else might happen on the same thread while it waits?” the answer is “anything at all”.
constexpr HRESULT E_TIMEOUT = HRESULT_FROM_WIN32( ERROR_TIMEOUT );
constexpr int MSGF_SLEEPMSG = 0x5300;
inline HRESULT getLastHr() { return HRESULT_FROM_WIN32( GetLastError() ); }
// Same as WaitForSingleObject but processes windows messages while it waits.
HRESULT msgWaitForSingleObject( HANDLE h, DWORD ms )
{
// https://blogs.msdn.microsoft.com/oldnewthing/20060126-00/?p=32513/
while( true )
{
const DWORD started = GetTickCount();
const DWORD res = MsgWaitForMultipleObjectsEx( 1, &h, ms, QS_ALLINPUT, MWMO_INPUTAVAILABLE );
if( WAIT_OBJECT_0 == res )
return S_OK;
if( WAIT_OBJECT_0 + 1 == res )
{
MSG msg;
while( PeekMessage( &msg, NULL, 0, 0, PM_REMOVE ) )
{
if( msg.message == WM_QUIT )
{
PostQuitMessage( (int)msg.wParam );
return S_FALSE; // Abandoned due to WM_QUIT
}
if( !CallMsgFilter( &msg, MSGF_SLEEPMSG ) )
{
TranslateMessage( &msg );
DispatchMessage( &msg );
}
}
const DWORD elapsed = GetTickCount() - started; //< This works OK even when DWORD overflows: https://codereview.stackexchange.com/a/129670/46194
if( elapsed > ms )
return E_TIMEOUT;
ms -= elapsed;
continue;
}
if( WAIT_TIMEOUT == res )
return E_TIMEOUT;
HRESULT hr = getLastHr();
if( FAILED( hr ) )
return hr;
return E_UNEXPECTED; // Unasked IO_COMPLETION or ABANDONED?
}
}
c++ winapi
asked 12 mins ago
Soonts
1534
Is this reliable, or have I missed something?
I want a drop-in replacement for WaitForSingleObject (sans the return type, I like HRESULT much better than any other error codes).
This code works in a plugin DLL for third party closed-source software. I don’t have source code of that app, i.e. if you ask “what else might happen on the same thread while it waits?” the answer is “anything at all”.
constexpr HRESULT E_TIMEOUT = HRESULT_FROM_WIN32( ERROR_TIMEOUT );
constexpr int MSGF_SLEEPMSG = 0x5300;
inline HRESULT getLastHr() { return HRESULT_FROM_WIN32( GetLastError() ); }
// Same as WaitForSingleObject but processes windows messages while it waits.
HRESULT msgWaitForSingleObject( HANDLE h, DWORD ms )
{
// https://blogs.msdn.microsoft.com/oldnewthing/20060126-00/?p=32513/
while( true )
{
const DWORD started = GetTickCount();
const DWORD res = MsgWaitForMultipleObjectsEx( 1, &h, ms, QS_ALLINPUT, MWMO_INPUTAVAILABLE );
if( WAIT_OBJECT_0 == res )
return S_OK;
if( WAIT_OBJECT_0 + 1 == res )
{
MSG msg;
while( PeekMessage( &msg, NULL, 0, 0, PM_REMOVE ) )
{
if( msg.message == WM_QUIT )
{
PostQuitMessage( (int)msg.wParam );
return S_FALSE; // Abandoned due to WM_QUIT
}
if( !CallMsgFilter( &msg, MSGF_SLEEPMSG ) )
{
TranslateMessage( &msg );
DispatchMessage( &msg );
}
}
const DWORD elapsed = GetTickCount() - started; //< This works OK even when DWORD overflows: https://codereview.stackexchange.com/a/129670/46194
if( elapsed > ms )
return E_TIMEOUT;
ms -= elapsed;
continue;
}
if( WAIT_TIMEOUT == res )
return E_TIMEOUT;
HRESULT hr = getLastHr();
if( FAILED( hr ) )
return hr;
return E_UNEXPECTED; // Unasked IO_COMPLETION or ABANDONED?
}
}
c++ winapi
c++ winapi
asked 12 mins ago
Soonts
1534
asked 12 mins ago
Soonts
1534
asked 12 mins ago
Soonts
1534
asked 12 mins ago
Soonts
1534
asked 12 mins ago
Soonts
1534
1534
add a comment |
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210399%2fwaitforsingleobject-with-windows-messages-processing%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210399%2fwaitforsingleobject-with-windows-messages-processing%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
