Cfrtjryk

I need to find whether the file is compressed or not in script.If it is compressed I need to uncompress and send as attachement. My find command results in two files sum12.pdf.Z and sum23.pdf.Z My script is

dir=/home/as1234/bills

cd $dir

for file in `find . -ctime -1 -type f -name "Sum*pdf*"`

do

if [ ${file: -1} == "Z" ]; then

echo "$file is Zipped"

uncompress $file

uuencode $file

fi

done

uuencode $file $file | mailx -s "subject" abc@gmail.com

when I ran this script I got error like

 ${file: -1}: 0403-011 The specified substitution is not valid for this command.

I am using ksh.

The filename suffix after the final dot may be had with ${file##*.}.

In this case though, I would consider doing the uncompressing and the uuencoding with find -exec directly like this:

#!/bin/sh



dir=/home/as1234/bills



find "$dir" -type f -ctime -1 -name "Sum*.pdf*" -exec sh -c '

    for pathname do

        filename=$( basename "${pathname%.pdf*}.pdf" )

        if [ "${pathname##*.}" = "Z" ]; then

            uncompress -c "$pathname"

        elif [ "${pathname##*.}" = "gz" ]; then

            gzip -cd "$pathname"

        else

            cat "$pathname"

        fi |

        uuencode "$filename" |

        mailx -s "subject ($filename)" abc@gmail.com

    done' sh {} +

This way, you would support pathnames with spaces and other troublesome characters. The sh -c script also does not store the uncompressed files but uncompresses them, uuencodes them and sends them in one go.

I also added handling of gzip-compressed files.

Related:

• Understanding the -exec option of `find`


• Why is looping over find's output bad practice?

Alternative implementation of the sh -c script using case ... esac instead of multiple if and elif statements.

find "$dir" -type f -ctime -1 -name "Sum*.pdf*" -exec sh -c '

    for pathname do

        filename=$( basename "${pathname%.pdf*}.pdf" )

        case $pathname in

            *.Z)  uncompress -c "$pathname" ;;

            *.gz) gzip -cd "$pathname" ;;

            *)    cat "$pathname"

        esac |

        uuencode "$filename" |

        mailx -s "subject ($filename)" abc@gmail.com

    done' sh {} +