Is this the correct implementation of builder pattern?
-1
I'm implementing builder pattern using fluent interface. So far I came up with:
My builder:
public interface IBuilder
{
byte File { get; }
List<Action> Actions { get; }
IBuilder SomeAction();
}
public class Builder : IBuilder
{
public byte File { get; private set; } = null;
public List<Action> Actions { get; }
public Builder()
{
this.Actions = new List<Action>();
}
public IBuilder SomeMethod()
{
Actions.Add(() =>
{ });
return this;
}
public IMyObject Build()
{
return new MyObject(this);
}
}
The object:
public interface IMyObject
{
byte File { get; }
void Run();
}
public class MyObject : IMyObject
{
private readonly IBuilder builder;
public byte File => builder.File;
public MyObject (IBuilder builder)
{
this.builder = builder;
}
public void Run()
{
builder.Actions.ForEach(x => x());
}
}
Is this the correct implementation?
c#
asked 1 hour ago
Ivan-Mark Debono
11413
add a comment |
-1
I'm implementing builder pattern using fluent interface. So far I came up with:
My builder:
public interface IBuilder
{
byte File { get; }
List<Action> Actions { get; }
IBuilder SomeAction();
}
public class Builder : IBuilder
{
public byte File { get; private set; } = null;
public List<Action> Actions { get; }
public Builder()
{
this.Actions = new List<Action>();
}
public IBuilder SomeMethod()
{
Actions.Add(() =>
{ });
return this;
}
public IMyObject Build()
{
return new MyObject(this);
}
}
The object:
public interface IMyObject
{
byte File { get; }
void Run();
}
public class MyObject : IMyObject
{
private readonly IBuilder builder;
public byte File => builder.File;
public MyObject (IBuilder builder)
{
this.builder = builder;
}
public void Run()
{
builder.Actions.ForEach(x => x());
}
}
Is this the correct implementation?
c#
asked 1 hour ago
Ivan-Mark Debono
11413
No it isn't correct because it wouldn't even compile. If you want code to be reviewed the code needs to be your real code. Voting to close now.
– Heslacher
1 hour ago
add a comment |
-1
-1
-1
I'm implementing builder pattern using fluent interface. So far I came up with:
My builder:
public interface IBuilder
{
byte File { get; }
List<Action> Actions { get; }
IBuilder SomeAction();
}
public class Builder : IBuilder
{
public byte File { get; private set; } = null;
public List<Action> Actions { get; }
public Builder()
{
this.Actions = new List<Action>();
}
public IBuilder SomeMethod()
{
Actions.Add(() =>
{ });
return this;
}
public IMyObject Build()
{
return new MyObject(this);
}
}
The object:
public interface IMyObject
{
byte File { get; }
void Run();
}
public class MyObject : IMyObject
{
private readonly IBuilder builder;
public byte File => builder.File;
public MyObject (IBuilder builder)
{
this.builder = builder;
}
public void Run()
{
builder.Actions.ForEach(x => x());
}
}
Is this the correct implementation?
c#
asked 1 hour ago
Ivan-Mark Debono
11413
I'm implementing builder pattern using fluent interface. So far I came up with:
My builder:
public interface IBuilder
{
byte File { get; }
List<Action> Actions { get; }
IBuilder SomeAction();
}
public class Builder : IBuilder
{
public byte File { get; private set; } = null;
public List<Action> Actions { get; }
public Builder()
{
this.Actions = new List<Action>();
}
public IBuilder SomeMethod()
{
Actions.Add(() =>
{ });
return this;
}
public IMyObject Build()
{
return new MyObject(this);
}
}
The object:
public interface IMyObject
{
byte File { get; }
void Run();
}
public class MyObject : IMyObject
{
private readonly IBuilder builder;
public byte File => builder.File;
public MyObject (IBuilder builder)
{
this.builder = builder;
}
public void Run()
{
builder.Actions.ForEach(x => x());
}
}
Is this the correct implementation?
c#
c#
asked 1 hour ago
Ivan-Mark Debono
11413
asked 1 hour ago
Ivan-Mark Debono
11413
asked 1 hour ago
Ivan-Mark Debono
11413
asked 1 hour ago
Ivan-Mark Debono
11413
asked 1 hour ago
Ivan-Mark Debono
11413
11413
No it isn't correct because it wouldn't even compile. If you want code to be reviewed the code needs to be your real code. Voting to close now.
– Heslacher
1 hour ago
add a comment |
No it isn't correct because it wouldn't even compile. If you want code to be reviewed the code needs to be your real code. Voting to close now.
– Heslacher
1 hour ago
No it isn't correct because it wouldn't even compile. If you want code to be reviewed the code needs to be your real code. Voting to close now.
– Heslacher
1 hour ago
No it isn't correct because it wouldn't even compile. If you want code to be reviewed the code needs to be your real code. Voting to close now.
– Heslacher
1 hour ago
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210487%2fis-this-the-correct-implementation-of-builder-pattern%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210487%2fis-this-the-correct-implementation-of-builder-pattern%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
No it isn't correct because it wouldn't even compile. If you want code to be reviewed the code needs to be your real code. Voting to close now.
– Heslacher
1 hour ago