Reactive Spring - Proper way to validate another mono
I'm fiddling with Spring webflux and reactive mongo db in a boot app
I've been reading but struggling to find the best way to do this logic:
I have entry & food services, entry service calls food service to validate that a food exists before saving that entry.
this is my create method in the EntryService
public Mono<Entry> create(Mono<Entry> entry) {
Mono<Food> err = Mono.error(new NotFound());
Mono<Entry> invalidEntry = Mono.error(new IllegalArgumentException());
return entry
.filter(this::isValideEntry)
.switchIfEmpty(invalidEntry)
.flatMap(e -> {
String foodId = e.getFood().getId();
return foodService.byId(foodId)
.switchIfEmpty(err)
.then(entryRepo.save(e));
});
}
private boolean isValideEntry(Entry e) {
return e.getAmount() > 0
&& e.getFood() != null
&& e.getFood().getId() != null;
}
food service has a webClient that calls the food service :
public Mono<Food> byId(String id) {
return webClient.get().uri("/{id}", id).retrieve().bodyToMono(Food.class);
}
im not sure if my code is idiomatic in terms of reactive streams in reactor.
it seems a bit messy how I'm validating that the food exists and switching back to save the entry.
I'm wondering if there is a better way to rewrite this.
java spring-mvc
asked 1 hour ago
Bashar Ali Labadi
101
New contributor
Bashar Ali Labadi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
I'm fiddling with Spring webflux and reactive mongo db in a boot app
I've been reading but struggling to find the best way to do this logic:
I have entry & food services, entry service calls food service to validate that a food exists before saving that entry.
this is my create method in the EntryService
public Mono<Entry> create(Mono<Entry> entry) {
Mono<Food> err = Mono.error(new NotFound());
Mono<Entry> invalidEntry = Mono.error(new IllegalArgumentException());
return entry
.filter(this::isValideEntry)
.switchIfEmpty(invalidEntry)
.flatMap(e -> {
String foodId = e.getFood().getId();
return foodService.byId(foodId)
.switchIfEmpty(err)
.then(entryRepo.save(e));
});
}
private boolean isValideEntry(Entry e) {
return e.getAmount() > 0
&& e.getFood() != null
&& e.getFood().getId() != null;
}
food service has a webClient that calls the food service :
public Mono<Food> byId(String id) {
return webClient.get().uri("/{id}", id).retrieve().bodyToMono(Food.class);
}
im not sure if my code is idiomatic in terms of reactive streams in reactor.
it seems a bit messy how I'm validating that the food exists and switching back to save the entry.
I'm wondering if there is a better way to rewrite this.
java spring-mvc
asked 1 hour ago
Bashar Ali Labadi
101
New contributor
Bashar Ali Labadi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
I'm fiddling with Spring webflux and reactive mongo db in a boot app
I've been reading but struggling to find the best way to do this logic:
I have entry & food services, entry service calls food service to validate that a food exists before saving that entry.
this is my create method in the EntryService
public Mono<Entry> create(Mono<Entry> entry) {
Mono<Food> err = Mono.error(new NotFound());
Mono<Entry> invalidEntry = Mono.error(new IllegalArgumentException());
return entry
.filter(this::isValideEntry)
.switchIfEmpty(invalidEntry)
.flatMap(e -> {
String foodId = e.getFood().getId();
return foodService.byId(foodId)
.switchIfEmpty(err)
.then(entryRepo.save(e));
});
}
private boolean isValideEntry(Entry e) {
return e.getAmount() > 0
&& e.getFood() != null
&& e.getFood().getId() != null;
}
food service has a webClient that calls the food service :
public Mono<Food> byId(String id) {
return webClient.get().uri("/{id}", id).retrieve().bodyToMono(Food.class);
}
im not sure if my code is idiomatic in terms of reactive streams in reactor.
it seems a bit messy how I'm validating that the food exists and switching back to save the entry.
I'm wondering if there is a better way to rewrite this.
java spring-mvc
asked 1 hour ago
Bashar Ali Labadi
101
New contributor
Bashar Ali Labadi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
I'm fiddling with Spring webflux and reactive mongo db in a boot app
I've been reading but struggling to find the best way to do this logic:
I have entry & food services, entry service calls food service to validate that a food exists before saving that entry.
this is my create method in the EntryService
public Mono<Entry> create(Mono<Entry> entry) {
Mono<Food> err = Mono.error(new NotFound());
Mono<Entry> invalidEntry = Mono.error(new IllegalArgumentException());
return entry
.filter(this::isValideEntry)
.switchIfEmpty(invalidEntry)
.flatMap(e -> {
String foodId = e.getFood().getId();
return foodService.byId(foodId)
.switchIfEmpty(err)
.then(entryRepo.save(e));
});
}
private boolean isValideEntry(Entry e) {
return e.getAmount() > 0
&& e.getFood() != null
&& e.getFood().getId() != null;
}
food service has a webClient that calls the food service :
public Mono<Food> byId(String id) {
return webClient.get().uri("/{id}", id).retrieve().bodyToMono(Food.class);
}
im not sure if my code is idiomatic in terms of reactive streams in reactor.
it seems a bit messy how I'm validating that the food exists and switching back to save the entry.
I'm wondering if there is a better way to rewrite this.
java spring-mvc
java spring-mvc
asked 1 hour ago
Bashar Ali Labadi
101
New contributor
Bashar Ali Labadi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 1 hour ago
Bashar Ali Labadi
101
New contributor
Bashar Ali Labadi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 1 hour ago
Bashar Ali Labadi
101
New contributor
Bashar Ali Labadi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 1 hour ago
Bashar Ali Labadi
101
asked 1 hour ago
Bashar Ali Labadi
101
101
New contributor
Bashar Ali Labadi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Bashar Ali Labadi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Bashar Ali Labadi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Bashar Ali Labadi is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210533%2freactive-spring-proper-way-to-validate-another-mono%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Bashar Ali Labadi is a new contributor. Be nice, and check out our Code of Conduct.
Bashar Ali Labadi is a new contributor. Be nice, and check out our Code of Conduct.
Bashar Ali Labadi is a new contributor. Be nice, and check out our Code of Conduct.
Bashar Ali Labadi is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210533%2freactive-spring-proper-way-to-validate-another-mono%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
