Counting the ones in the binary representation of a number in C# [on hold]











up vote
-1
down vote

favorite












I want to count the 1s in the binary representation of a number (input) in C#.



Which is more readable:



Enumerable

   .Range(0, 32)

   .Aggregate(0, (acc, i) => acc + ((input >> i) & 1));


or



Convert.ToString(input, 2).Count(x => x == '1');





c# comparative-review linq







share|improve this question















put on hold as off-topic by t3chb0t, Toby Speight, IEatBagels, Mast, Ismael Miguel 15 hours ago


This question appears to be off-topic. The users who voted to close gave this specific reason:


  • "Lacks concrete context: Code Review requires concrete code from a project, with sufficient context for reviewers to understand how that code is used. Pseudocode, stub code, hypothetical code, obfuscated code, and generic best practices are outside the scope of this site." – t3chb0t, Toby Speight, IEatBagels, Mast

If this question can be reworded to fit the rules in the help center, please edit the question.













  • Why the downvote?
    – K. Gkinis
    yesterday






  • 1




    I can't speak for the person that downvoted, but your question is getting some close-votes for 'lack of context' - it would help to know in what context this code is used. Either way, I'd say that the more readable solution is to encapsulate this logic in a BitCount(int input) method. Not only does it make the intent clearer at call-sites, it also allows you to swap for a more efficient approach if the need arises.
    – Pieter Witvoet
    18 hours ago










  • Unfortunately, there is no better context. It's not actual code, it's more of an argument over readability over an exercise, so maybe it's too broad.
    – K. Gkinis
    17 hours ago















up vote
-1
down vote

favorite












I want to count the 1s in the binary representation of a number (input) in C#.



Which is more readable:



Enumerable

   .Range(0, 32)

   .Aggregate(0, (acc, i) => acc + ((input >> i) & 1));


or



Convert.ToString(input, 2).Count(x => x == '1');





c# comparative-review linq







share|improve this question















put on hold as off-topic by t3chb0t, Toby Speight, IEatBagels, Mast, Ismael Miguel 15 hours ago


This question appears to be off-topic. The users who voted to close gave this specific reason:


  • "Lacks concrete context: Code Review requires concrete code from a project, with sufficient context for reviewers to understand how that code is used. Pseudocode, stub code, hypothetical code, obfuscated code, and generic best practices are outside the scope of this site." – t3chb0t, Toby Speight, IEatBagels, Mast

If this question can be reworded to fit the rules in the help center, please edit the question.













  • Why the downvote?
    – K. Gkinis
    yesterday






  • 1




    I can't speak for the person that downvoted, but your question is getting some close-votes for 'lack of context' - it would help to know in what context this code is used. Either way, I'd say that the more readable solution is to encapsulate this logic in a BitCount(int input) method. Not only does it make the intent clearer at call-sites, it also allows you to swap for a more efficient approach if the need arises.
    – Pieter Witvoet
    18 hours ago










  • Unfortunately, there is no better context. It's not actual code, it's more of an argument over readability over an exercise, so maybe it's too broad.
    – K. Gkinis
    17 hours ago













up vote
-1
down vote

favorite









up vote
-1
down vote

favorite











I want to count the 1s in the binary representation of a number (input) in C#.



Which is more readable:



Enumerable

   .Range(0, 32)

   .Aggregate(0, (acc, i) => acc + ((input >> i) & 1));


or



Convert.ToString(input, 2).Count(x => x == '1');





c# comparative-review linq







share|improve this question















I want to count the 1s in the binary representation of a number (input) in C#.



Which is more readable:



Enumerable

   .Range(0, 32)

   .Aggregate(0, (acc, i) => acc + ((input >> i) & 1));


or



Convert.ToString(input, 2).Count(x => x == '1');





c# comparative-review linq




c# comparative-review linq






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited yesterday









200_success

127k15149412




127k15149412










asked yesterday









K. Gkinis

1175




1175




put on hold as off-topic by t3chb0t, Toby Speight, IEatBagels, Mast, Ismael Miguel 15 hours ago


This question appears to be off-topic. The users who voted to close gave this specific reason:


  • "Lacks concrete context: Code Review requires concrete code from a project, with sufficient context for reviewers to understand how that code is used. Pseudocode, stub code, hypothetical code, obfuscated code, and generic best practices are outside the scope of this site." – t3chb0t, Toby Speight, IEatBagels, Mast

If this question can be reworded to fit the rules in the help center, please edit the question.




put on hold as off-topic by t3chb0t, Toby Speight, IEatBagels, Mast, Ismael Miguel 15 hours ago


This question appears to be off-topic. The users who voted to close gave this specific reason:


  • "Lacks concrete context: Code Review requires concrete code from a project, with sufficient context for reviewers to understand how that code is used. Pseudocode, stub code, hypothetical code, obfuscated code, and generic best practices are outside the scope of this site." – t3chb0t, Toby Speight, IEatBagels, Mast

If this question can be reworded to fit the rules in the help center, please edit the question.












  • Why the downvote?
    – K. Gkinis
    yesterday






  • 1




    I can't speak for the person that downvoted, but your question is getting some close-votes for 'lack of context' - it would help to know in what context this code is used. Either way, I'd say that the more readable solution is to encapsulate this logic in a BitCount(int input) method. Not only does it make the intent clearer at call-sites, it also allows you to swap for a more efficient approach if the need arises.
    – Pieter Witvoet
    18 hours ago










  • Unfortunately, there is no better context. It's not actual code, it's more of an argument over readability over an exercise, so maybe it's too broad.
    – K. Gkinis
    17 hours ago


















  • Why the downvote?
    – K. Gkinis
    yesterday






  • 1




    I can't speak for the person that downvoted, but your question is getting some close-votes for 'lack of context' - it would help to know in what context this code is used. Either way, I'd say that the more readable solution is to encapsulate this logic in a BitCount(int input) method. Not only does it make the intent clearer at call-sites, it also allows you to swap for a more efficient approach if the need arises.
    – Pieter Witvoet
    18 hours ago










  • Unfortunately, there is no better context. It's not actual code, it's more of an argument over readability over an exercise, so maybe it's too broad.
    – K. Gkinis
    17 hours ago
















Why the downvote?
– K. Gkinis
yesterday




Why the downvote?
– K. Gkinis
yesterday




1




1




I can't speak for the person that downvoted, but your question is getting some close-votes for 'lack of context' - it would help to know in what context this code is used. Either way, I'd say that the more readable solution is to encapsulate this logic in a BitCount(int input) method. Not only does it make the intent clearer at call-sites, it also allows you to swap for a more efficient approach if the need arises.
– Pieter Witvoet
18 hours ago




I can't speak for the person that downvoted, but your question is getting some close-votes for 'lack of context' - it would help to know in what context this code is used. Either way, I'd say that the more readable solution is to encapsulate this logic in a BitCount(int input) method. Not only does it make the intent clearer at call-sites, it also allows you to swap for a more efficient approach if the need arises.
– Pieter Witvoet
18 hours ago












Unfortunately, there is no better context. It's not actual code, it's more of an argument over readability over an exercise, so maybe it's too broad.
– K. Gkinis
17 hours ago




Unfortunately, there is no better context. It's not actual code, it's more of an argument over readability over an exercise, so maybe it's too broad.
– K. Gkinis
17 hours ago















active

oldest

votes






















active

oldest

votes













active

oldest

votes









active

oldest

votes






active

oldest

votes

-

Popular posts from this blog

Scott Moir

Image
Scott Moir Tessa Virtue i Scott Moir w 2016 r. Reprezentacja   Kanada Data i miejsce urodzenia 2 września 1987 London Wzrost 180 cm Konkurencja Pary taneczne Partner sportowy Tessa Virtue Trener Marie-France Dubreuil, Patrice Lauzon, Romain Haguenauer Poprzednio: Marina Zujewa, Oleg Epstein, Igor Szpilband, Johnny Johns, Carol Moir, Paul MacIntosh, Suzanne Killing Klub Montreal International School of Skating Poprzednio: Arctic Edge FSC Ilderton Skating Club Lokalizacja treningowa Montreal Poprzednio: Canton Kitchener Rekordy życiowe ISU przed sezonem 2018/2019 Nota łączna 206,07 Igrzyska Olimpijskie 2018 Taniec krótki 83,67 Igrzyska Olimpijskie 2018 Taniec dowolny 122,40 Igrzyska Olimpijskie 2018 Dorobek medalowy Reprezentacja   Kanada Igrzyska olimpijskie Złoto Vancouver 2010 pary taneczne Złoto Pjongczang 2018 pary taneczne Złoto Pjongczang 2018 drużynowo Srebro S...
Read more

Województwo

Image
Podział administracyjny Polski (stan na 1 stycznia 2010) Województwo – jednostka podziału administracyjnego najwyższego stopnia w Polsce, od 1990 r. jednostka zasadniczego podziału terytorialnego administracji rządowej, od 1999 r. także jednostka samorządu terytorialnego. Podział kraju na województwa ma swoje korzenie w okresie rozbicia dzielnicowego, stąd ich zróżnicowanie pod względem wielkości w czasach Rzeczypospolitej. Pierwsze województwa powstawały na przełomie XIV i XV w. Pierwotnie były to samodzielne zgromadzenia wojskowe na określonych terenach Polski, którymi zarządzali wyznaczani przez władcę wojewodowie – od: wodzić woje. Status województwa reguluje w Polsce ustawa o samorządzie województwa z dnia 5 czerwca 1998 r. [1] Spis treści 1 Liczba województw 2 Stan aktualny – 16 województw 2.1 Podział na województwa od 1999 r. 3 Województwa w przeszłości 3.1 Pierwsze województwa w Polsce 3.2 Województwa w okresie I Rzeczypospolitej 3....
Read more

What dialect is “You wants I should do it for ya?”

Image
0 I heard this phrasing in an episode of a TV show, but I can't remember what for the life of me. I just remember how weird it sounded, because no one else talked like that in the series? It was a white character in a rural setting, if that helps. A criminal henchman. Is there an area or something where "You wants I..." is commonplace? slang dialects share | improve this question asked 12 hours ago Patroclus 21 2 2 ...
Read more