Cfrtjryk

What is wrong with my script?

Script:

Success: $(grep success * | grep B2B | wc -l)

etc_error: $(grep etc_error * | grep B2B | wc -l)

map_timeout: $(grep map_timeout * | grep B2B | wc -l)



success=$(grep success * | grep B2B | wc -l)

etc=$(grep etc_error * | grep B2B | wc -l)

map=$(grep map_timeout * | grep B2B | wc -l)



sum=$(($success + $etc + $map))

total=$(($success / $sum))

echo $total

Error:

-bash: + + : syntax error: operand expected (error token is "+ ")

Thanks!

This doesn’t explain everything — given your variable declarations, they should have a value — but since you’re using arithmetic expansion, you don’t need $ to introduce variables; undefined variables then default to 0:

sum=$((success + etc + map))

total=$((success / sum))

echo "$total"

Ideally you should check that sum is non-zero before dividing, but at least you’ll get a sensible error message with this approach even if you don’t check sum (“division by 0” rather than “syntax error: operand expected”, in bash).

The error you’re getting comes from

sum=$(($success + $etc + $map))

For some reason, success, etc and map are all undefined or empty. The shell expands the above to

sum=$(( + + ))

and then tries to expand that, which results in the syntax error you quote.

This is rather surprising though since

success=$(grep success * | grep B2B | wc -l)

should produce a value...

BTW, You may want to improve the above to:

success=$(grep success ./* | grep -c B2B)

or, if B2B is to be matched on the content of the success lines and not on the file names:

success=$(cat ./* | grep success | grep -c B2B)

or with GNU grep or compatible:

success=$(grep -h success ./* | grep -c B2B)

you have to check your variables before the addition, because if one of then is not set or has no numeric value
the addition syntax will fail

you can defaulty set vars to 0 before setting then to avoid that.