Find the number of elements larger than a given element in BST
I'm trying to solve the Hackerrank's Insertion Sort Advanced Analysis problem using BST (similar to this question on SO). As I put items in the tree, I need to find out the number of items greater than it (the get_rank() method in the code):
class Node:
def __init__(self, data):
self.left = None
self.right = None
self.data = data
self.num_left_children = 0
self.num_right_children = 0
def insert(self, data):
if data <= self.data:
if self.left is None:
self.left = Node(data)
else:
self.left.insert(data)
self.num_left_children += 1
else:
if self.right is None:
self.right = Node(data)
else:
self.right.insert(data)
self.num_right_children += 1
def get_rank(self, data):
if data < self.data:
return self.num_right_children + self.left.get_rank(data) + 1
elif data > self.data:
return self.right.get_rank(data)
else:
return self.num_right_children
How can I improve the performance of this code (e.g. in case multiple identical items are put into the tree) ?
python performance python-3.x time-limit-exceeded tree
asked 19 mins ago
Eugene Yarmash
26329
add a comment |
I'm trying to solve the Hackerrank's Insertion Sort Advanced Analysis problem using BST (similar to this question on SO). As I put items in the tree, I need to find out the number of items greater than it (the get_rank() method in the code):
class Node:
def __init__(self, data):
self.left = None
self.right = None
self.data = data
self.num_left_children = 0
self.num_right_children = 0
def insert(self, data):
if data <= self.data:
if self.left is None:
self.left = Node(data)
else:
self.left.insert(data)
self.num_left_children += 1
else:
if self.right is None:
self.right = Node(data)
else:
self.right.insert(data)
self.num_right_children += 1
def get_rank(self, data):
if data < self.data:
return self.num_right_children + self.left.get_rank(data) + 1
elif data > self.data:
return self.right.get_rank(data)
else:
return self.num_right_children
How can I improve the performance of this code (e.g. in case multiple identical items are put into the tree) ?
python performance python-3.x time-limit-exceeded tree
asked 19 mins ago
Eugene Yarmash
26329
add a comment |
I'm trying to solve the Hackerrank's Insertion Sort Advanced Analysis problem using BST (similar to this question on SO). As I put items in the tree, I need to find out the number of items greater than it (the get_rank() method in the code):
class Node:
def __init__(self, data):
self.left = None
self.right = None
self.data = data
self.num_left_children = 0
self.num_right_children = 0
def insert(self, data):
if data <= self.data:
if self.left is None:
self.left = Node(data)
else:
self.left.insert(data)
self.num_left_children += 1
else:
if self.right is None:
self.right = Node(data)
else:
self.right.insert(data)
self.num_right_children += 1
def get_rank(self, data):
if data < self.data:
return self.num_right_children + self.left.get_rank(data) + 1
elif data > self.data:
return self.right.get_rank(data)
else:
return self.num_right_children
How can I improve the performance of this code (e.g. in case multiple identical items are put into the tree) ?
python performance python-3.x time-limit-exceeded tree
asked 19 mins ago
Eugene Yarmash
26329
I'm trying to solve the Hackerrank's Insertion Sort Advanced Analysis problem using BST (similar to this question on SO). As I put items in the tree, I need to find out the number of items greater than it (the get_rank() method in the code):
class Node:
def __init__(self, data):
self.left = None
self.right = None
self.data = data
self.num_left_children = 0
self.num_right_children = 0
def insert(self, data):
if data <= self.data:
if self.left is None:
self.left = Node(data)
else:
self.left.insert(data)
self.num_left_children += 1
else:
if self.right is None:
self.right = Node(data)
else:
self.right.insert(data)
self.num_right_children += 1
def get_rank(self, data):
if data < self.data:
return self.num_right_children + self.left.get_rank(data) + 1
elif data > self.data:
return self.right.get_rank(data)
else:
return self.num_right_children
How can I improve the performance of this code (e.g. in case multiple identical items are put into the tree) ?
python performance python-3.x time-limit-exceeded tree
python performance python-3.x time-limit-exceeded tree
asked 19 mins ago
Eugene Yarmash
26329
asked 19 mins ago
Eugene Yarmash
26329
asked 19 mins ago
Eugene Yarmash
26329
asked 19 mins ago
Eugene Yarmash
26329
asked 19 mins ago
Eugene Yarmash
26329
26329
add a comment |
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210303%2ffind-the-number-of-elements-larger-than-a-given-element-in-bst%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210303%2ffind-the-number-of-elements-larger-than-a-given-element-in-bst%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
