Simple Trie implementation but results different in other environment
0
I am trying to implement a simple Trie data structure with addWord and search methods:
#ifndef WORD_DICTIONARY_H
#define WORD_DICTIONARY_H
#include <iostream>
#include <string>
#include <unordered_map>
using namespace std;
class TrieNode {
public:
unordered_map<char, TrieNode*> children;
bool isWord = false;
~TrieNode() {
for (auto it = children.begin(); it != children.end(); ++it) {
delete it->second;
}
}
};
class WordDictionary {
public:
TrieNode* root = new TrieNode();
WordDictionary() {}
~WordDictionary() {
delete root;
}
/*
* @param word: Adds a word into the data structure.
* @return: nothing
*/
void addWord(const string &word) {
// write your code here
TrieNode* node = root;
for (size_t i = 0; i < word.size(); ++i) {
auto it = node->children.find(word[i]);
if (it == node->children.end()) {
TrieNode* next = new TrieNode();
node->children.insert(make_pair(word.at(i), next));
}
node = node->children.find(word[i])->second;
}
node->isWord = true;
}
/*
* @param word: A word could contain the dot character '.' to represent any one letter.
* @return: if the word is in the data structure.
*/
bool search(const string &word) {
// write your code
if (word.size() == 0) {
return false;
}
searchHelper(word, 0, root);
}
bool searchHelper(const string& word, int pos, TrieNode* node) const {
//cout << word << " "<<pos<<" "<< node->isWord<< endl;
if (pos == word.size() && node->isWord) {
return true;
}
auto children = node->children;
if (word[pos] == '.') {
for (auto it = children.begin(); it != children.end(); ++it) {
return searchHelper(word, pos + 1, it->second);
}
}
else {
auto it = children.find(word[pos]);
if (it == children.end()) {
return false;
}
else {
return searchHelper(word, pos + 1, it->second);
}
}
}
};
#endif // !WORD_DICTIONARY_HBut the code here doesn't work well in other computers, don't know why, thanks!
Code Question Here: enter link description here
c++
asked 14 mins ago
MrROY
136114
add a comment |
0
I am trying to implement a simple Trie data structure with addWord and search methods:
#ifndef WORD_DICTIONARY_H
#define WORD_DICTIONARY_H
#include <iostream>
#include <string>
#include <unordered_map>
using namespace std;
class TrieNode {
public:
unordered_map<char, TrieNode*> children;
bool isWord = false;
~TrieNode() {
for (auto it = children.begin(); it != children.end(); ++it) {
delete it->second;
}
}
};
class WordDictionary {
public:
TrieNode* root = new TrieNode();
WordDictionary() {}
~WordDictionary() {
delete root;
}
/*
* @param word: Adds a word into the data structure.
* @return: nothing
*/
void addWord(const string &word) {
// write your code here
TrieNode* node = root;
for (size_t i = 0; i < word.size(); ++i) {
auto it = node->children.find(word[i]);
if (it == node->children.end()) {
TrieNode* next = new TrieNode();
node->children.insert(make_pair(word.at(i), next));
}
node = node->children.find(word[i])->second;
}
node->isWord = true;
}
/*
* @param word: A word could contain the dot character '.' to represent any one letter.
* @return: if the word is in the data structure.
*/
bool search(const string &word) {
// write your code
if (word.size() == 0) {
return false;
}
searchHelper(word, 0, root);
}
bool searchHelper(const string& word, int pos, TrieNode* node) const {
//cout << word << " "<<pos<<" "<< node->isWord<< endl;
if (pos == word.size() && node->isWord) {
return true;
}
auto children = node->children;
if (word[pos] == '.') {
for (auto it = children.begin(); it != children.end(); ++it) {
return searchHelper(word, pos + 1, it->second);
}
}
else {
auto it = children.find(word[pos]);
if (it == children.end()) {
return false;
}
else {
return searchHelper(word, pos + 1, it->second);
}
}
}
};
#endif // !WORD_DICTIONARY_HBut the code here doesn't work well in other computers, don't know why, thanks!
Code Question Here: enter link description here
c++
asked 14 mins ago
MrROY
136114
add a comment |
0
0
0
I am trying to implement a simple Trie data structure with addWord and search methods:
#ifndef WORD_DICTIONARY_H
#define WORD_DICTIONARY_H
#include <iostream>
#include <string>
#include <unordered_map>
using namespace std;
class TrieNode {
public:
unordered_map<char, TrieNode*> children;
bool isWord = false;
~TrieNode() {
for (auto it = children.begin(); it != children.end(); ++it) {
delete it->second;
}
}
};
class WordDictionary {
public:
TrieNode* root = new TrieNode();
WordDictionary() {}
~WordDictionary() {
delete root;
}
/*
* @param word: Adds a word into the data structure.
* @return: nothing
*/
void addWord(const string &word) {
// write your code here
TrieNode* node = root;
for (size_t i = 0; i < word.size(); ++i) {
auto it = node->children.find(word[i]);
if (it == node->children.end()) {
TrieNode* next = new TrieNode();
node->children.insert(make_pair(word.at(i), next));
}
node = node->children.find(word[i])->second;
}
node->isWord = true;
}
/*
* @param word: A word could contain the dot character '.' to represent any one letter.
* @return: if the word is in the data structure.
*/
bool search(const string &word) {
// write your code
if (word.size() == 0) {
return false;
}
searchHelper(word, 0, root);
}
bool searchHelper(const string& word, int pos, TrieNode* node) const {
//cout << word << " "<<pos<<" "<< node->isWord<< endl;
if (pos == word.size() && node->isWord) {
return true;
}
auto children = node->children;
if (word[pos] == '.') {
for (auto it = children.begin(); it != children.end(); ++it) {
return searchHelper(word, pos + 1, it->second);
}
}
else {
auto it = children.find(word[pos]);
if (it == children.end()) {
return false;
}
else {
return searchHelper(word, pos + 1, it->second);
}
}
}
};
#endif // !WORD_DICTIONARY_HBut the code here doesn't work well in other computers, don't know why, thanks!
Code Question Here: enter link description here
c++
asked 14 mins ago
MrROY
136114
I am trying to implement a simple Trie data structure with addWord and search methods:
#ifndef WORD_DICTIONARY_H
#define WORD_DICTIONARY_H
#include <iostream>
#include <string>
#include <unordered_map>
using namespace std;
class TrieNode {
public:
unordered_map<char, TrieNode*> children;
bool isWord = false;
~TrieNode() {
for (auto it = children.begin(); it != children.end(); ++it) {
delete it->second;
}
}
};
class WordDictionary {
public:
TrieNode* root = new TrieNode();
WordDictionary() {}
~WordDictionary() {
delete root;
}
/*
* @param word: Adds a word into the data structure.
* @return: nothing
*/
void addWord(const string &word) {
// write your code here
TrieNode* node = root;
for (size_t i = 0; i < word.size(); ++i) {
auto it = node->children.find(word[i]);
if (it == node->children.end()) {
TrieNode* next = new TrieNode();
node->children.insert(make_pair(word.at(i), next));
}
node = node->children.find(word[i])->second;
}
node->isWord = true;
}
/*
* @param word: A word could contain the dot character '.' to represent any one letter.
* @return: if the word is in the data structure.
*/
bool search(const string &word) {
// write your code
if (word.size() == 0) {
return false;
}
searchHelper(word, 0, root);
}
bool searchHelper(const string& word, int pos, TrieNode* node) const {
//cout << word << " "<<pos<<" "<< node->isWord<< endl;
if (pos == word.size() && node->isWord) {
return true;
}
auto children = node->children;
if (word[pos] == '.') {
for (auto it = children.begin(); it != children.end(); ++it) {
return searchHelper(word, pos + 1, it->second);
}
}
else {
auto it = children.find(word[pos]);
if (it == children.end()) {
return false;
}
else {
return searchHelper(word, pos + 1, it->second);
}
}
}
};
#endif // !WORD_DICTIONARY_HBut the code here doesn't work well in other computers, don't know why, thanks!
Code Question Here: enter link description here
#ifndef WORD_DICTIONARY_H
#define WORD_DICTIONARY_H
#include <iostream>
#include <string>
#include <unordered_map>
using namespace std;
class TrieNode {
public:
unordered_map<char, TrieNode*> children;
bool isWord = false;
~TrieNode() {
for (auto it = children.begin(); it != children.end(); ++it) {
delete it->second;
}
}
};
class WordDictionary {
public:
TrieNode* root = new TrieNode();
WordDictionary() {}
~WordDictionary() {
delete root;
}
/*
* @param word: Adds a word into the data structure.
* @return: nothing
*/
void addWord(const string &word) {
// write your code here
TrieNode* node = root;
for (size_t i = 0; i < word.size(); ++i) {
auto it = node->children.find(word[i]);
if (it == node->children.end()) {
TrieNode* next = new TrieNode();
node->children.insert(make_pair(word.at(i), next));
}
node = node->children.find(word[i])->second;
}
node->isWord = true;
}
/*
* @param word: A word could contain the dot character '.' to represent any one letter.
* @return: if the word is in the data structure.
*/
bool search(const string &word) {
// write your code
if (word.size() == 0) {
return false;
}
searchHelper(word, 0, root);
}
bool searchHelper(const string& word, int pos, TrieNode* node) const {
//cout << word << " "<<pos<<" "<< node->isWord<< endl;
if (pos == word.size() && node->isWord) {
return true;
}
auto children = node->children;
if (word[pos] == '.') {
for (auto it = children.begin(); it != children.end(); ++it) {
return searchHelper(word, pos + 1, it->second);
}
}
else {
auto it = children.find(word[pos]);
if (it == children.end()) {
return false;
}
else {
return searchHelper(word, pos + 1, it->second);
}
}
}
};
#endif // !WORD_DICTIONARY_H#ifndef WORD_DICTIONARY_H
#define WORD_DICTIONARY_H
#include <iostream>
#include <string>
#include <unordered_map>
using namespace std;
class TrieNode {
public:
unordered_map<char, TrieNode*> children;
bool isWord = false;
~TrieNode() {
for (auto it = children.begin(); it != children.end(); ++it) {
delete it->second;
}
}
};
class WordDictionary {
public:
TrieNode* root = new TrieNode();
WordDictionary() {}
~WordDictionary() {
delete root;
}
/*
* @param word: Adds a word into the data structure.
* @return: nothing
*/
void addWord(const string &word) {
// write your code here
TrieNode* node = root;
for (size_t i = 0; i < word.size(); ++i) {
auto it = node->children.find(word[i]);
if (it == node->children.end()) {
TrieNode* next = new TrieNode();
node->children.insert(make_pair(word.at(i), next));
}
node = node->children.find(word[i])->second;
}
node->isWord = true;
}
/*
* @param word: A word could contain the dot character '.' to represent any one letter.
* @return: if the word is in the data structure.
*/
bool search(const string &word) {
// write your code
if (word.size() == 0) {
return false;
}
searchHelper(word, 0, root);
}
bool searchHelper(const string& word, int pos, TrieNode* node) const {
//cout << word << " "<<pos<<" "<< node->isWord<< endl;
if (pos == word.size() && node->isWord) {
return true;
}
auto children = node->children;
if (word[pos] == '.') {
for (auto it = children.begin(); it != children.end(); ++it) {
return searchHelper(word, pos + 1, it->second);
}
}
else {
auto it = children.find(word[pos]);
if (it == children.end()) {
return false;
}
else {
return searchHelper(word, pos + 1, it->second);
}
}
}
};
#endif // !WORD_DICTIONARY_Hc++
c++
asked 14 mins ago
MrROY
136114
asked 14 mins ago
MrROY
136114
asked 14 mins ago
MrROY
136114
asked 14 mins ago
MrROY
136114
asked 14 mins ago
MrROY
136114
136114
add a comment |
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210094%2fsimple-trie-implementation-but-results-different-in-other-environment%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210094%2fsimple-trie-implementation-but-results-different-in-other-environment%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
