Credit Card Validator python 3.7.1











up vote
0
down vote

favorite












I am doing some projects so i can teach myself programming. The one that i finished states:
"Credit Card Validator - Takes in a credit card number from a common credit card vendor and validates it to make sure that it is a valid number (look into how credit cards use a checksum)."
Would be glad if i can get a constructive feedback on this one.



import sys

cardnumb_input = input('Enter your credit card number: ')


def list_tweak():
try:
cardnumb = [int(i) for i in cardnumb_input]
cardnumb[0::2] = [x * 2 for x in cardnumb[0::2]]
cardnumb = [str(i) for i in cardnumb]
cardnumb = list(''.join(cardnumb))
cardnumb = [int(i) for i in cardnumb]
return cardnumb

except ValueError:
print('Please enter only number in format: xxxxxxxxxxxxxxxx')
sys.exit(1)


def valid_or_not():
total = sum(list_tweak())
if total % 10 != 0:
print('It seems that this credit card number is not valid.')
else:
print('This credit card number is valid. ')


valid_or_not()









share|improve this question


























    up vote
    0
    down vote

    favorite












    I am doing some projects so i can teach myself programming. The one that i finished states:
    "Credit Card Validator - Takes in a credit card number from a common credit card vendor and validates it to make sure that it is a valid number (look into how credit cards use a checksum)."
    Would be glad if i can get a constructive feedback on this one.



    import sys

    cardnumb_input = input('Enter your credit card number: ')


    def list_tweak():
    try:
    cardnumb = [int(i) for i in cardnumb_input]
    cardnumb[0::2] = [x * 2 for x in cardnumb[0::2]]
    cardnumb = [str(i) for i in cardnumb]
    cardnumb = list(''.join(cardnumb))
    cardnumb = [int(i) for i in cardnumb]
    return cardnumb

    except ValueError:
    print('Please enter only number in format: xxxxxxxxxxxxxxxx')
    sys.exit(1)


    def valid_or_not():
    total = sum(list_tweak())
    if total % 10 != 0:
    print('It seems that this credit card number is not valid.')
    else:
    print('This credit card number is valid. ')


    valid_or_not()









    share|improve this question
























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      I am doing some projects so i can teach myself programming. The one that i finished states:
      "Credit Card Validator - Takes in a credit card number from a common credit card vendor and validates it to make sure that it is a valid number (look into how credit cards use a checksum)."
      Would be glad if i can get a constructive feedback on this one.



      import sys

      cardnumb_input = input('Enter your credit card number: ')


      def list_tweak():
      try:
      cardnumb = [int(i) for i in cardnumb_input]
      cardnumb[0::2] = [x * 2 for x in cardnumb[0::2]]
      cardnumb = [str(i) for i in cardnumb]
      cardnumb = list(''.join(cardnumb))
      cardnumb = [int(i) for i in cardnumb]
      return cardnumb

      except ValueError:
      print('Please enter only number in format: xxxxxxxxxxxxxxxx')
      sys.exit(1)


      def valid_or_not():
      total = sum(list_tweak())
      if total % 10 != 0:
      print('It seems that this credit card number is not valid.')
      else:
      print('This credit card number is valid. ')


      valid_or_not()









      share|improve this question













      I am doing some projects so i can teach myself programming. The one that i finished states:
      "Credit Card Validator - Takes in a credit card number from a common credit card vendor and validates it to make sure that it is a valid number (look into how credit cards use a checksum)."
      Would be glad if i can get a constructive feedback on this one.



      import sys

      cardnumb_input = input('Enter your credit card number: ')


      def list_tweak():
      try:
      cardnumb = [int(i) for i in cardnumb_input]
      cardnumb[0::2] = [x * 2 for x in cardnumb[0::2]]
      cardnumb = [str(i) for i in cardnumb]
      cardnumb = list(''.join(cardnumb))
      cardnumb = [int(i) for i in cardnumb]
      return cardnumb

      except ValueError:
      print('Please enter only number in format: xxxxxxxxxxxxxxxx')
      sys.exit(1)


      def valid_or_not():
      total = sum(list_tweak())
      if total % 10 != 0:
      print('It seems that this credit card number is not valid.')
      else:
      print('This credit card number is valid. ')


      valid_or_not()






      python beginner python-3.x programming-challenge






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 2 hours ago









      skyn37

      384




      384



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209326%2fcredit-card-validator-python-3-7-1%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209326%2fcredit-card-validator-python-3-7-1%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Morgemoulin

          Scott Moir

          Souastre