Verifying a set (card game) in F#
The game of Set involves cards with four properties: number, symbol, shading, and colour.
Three cards make a "Set" if the property is either all the same or all different across the three cards, for each of the four properties.
I wrote some code to verify if three cards constitute a "Set". But I'm not satisfied with the final function isSet. I feel there should be some way to iterate over the four properties instead of writing four separate lines. Any help would be appreciated - I'm fairly new to F#.
type Number = | One | Two | Three
type Symbol = | Round | Wavy | Diamond
type Shading = | Empty | Lines | Full
type Colour = | Red | Green | Blue
type Card = {number: Number;
symbol: Symbol;
shading: Shading;
colour: Colour}
let all =
List.reduce (=)
let numUnique list =
list
|> List.distinct
|> List.length
let allSame list =
list
|> numUnique
|> (=) 1
let allUnique list =
let length = List.length list
list
|> numUnique
|> (=) length
let allSameOrUnique list =
allSame list || allUnique list
let isSet card1 card2 card3 =
let check1 = allSameOrUnique [card1.number; card2.number; card3.number]
let check2 = allSameOrUnique [card1.symbol; card2.symbol; card3.symbol]
let check3 = allSameOrUnique [card1.shading; card2.shading; card3.shading]
let check4 = allSameOrUnique [card1.colour; card2.colour; card3.colour]
all [check1; check2; check3; check3; check4]
let card1 = {number = Two; symbol = Round; shading = Lines; colour = Green}
let card2 = {number = One; symbol = Round; shading = Empty; colour = Green}
let card3 = {number = Three; symbol = Round; shading = Full; colour = Green}
The final function returns a boolean for verifying the set:
> isSet card1 card2 card3
val it : bool = true
beginner f#
asked 11 mins ago
Vermillion
4881517
add a comment |
The game of Set involves cards with four properties: number, symbol, shading, and colour.
Three cards make a "Set" if the property is either all the same or all different across the three cards, for each of the four properties.
I wrote some code to verify if three cards constitute a "Set". But I'm not satisfied with the final function isSet. I feel there should be some way to iterate over the four properties instead of writing four separate lines. Any help would be appreciated - I'm fairly new to F#.
type Number = | One | Two | Three
type Symbol = | Round | Wavy | Diamond
type Shading = | Empty | Lines | Full
type Colour = | Red | Green | Blue
type Card = {number: Number;
symbol: Symbol;
shading: Shading;
colour: Colour}
let all =
List.reduce (=)
let numUnique list =
list
|> List.distinct
|> List.length
let allSame list =
list
|> numUnique
|> (=) 1
let allUnique list =
let length = List.length list
list
|> numUnique
|> (=) length
let allSameOrUnique list =
allSame list || allUnique list
let isSet card1 card2 card3 =
let check1 = allSameOrUnique [card1.number; card2.number; card3.number]
let check2 = allSameOrUnique [card1.symbol; card2.symbol; card3.symbol]
let check3 = allSameOrUnique [card1.shading; card2.shading; card3.shading]
let check4 = allSameOrUnique [card1.colour; card2.colour; card3.colour]
all [check1; check2; check3; check3; check4]
let card1 = {number = Two; symbol = Round; shading = Lines; colour = Green}
let card2 = {number = One; symbol = Round; shading = Empty; colour = Green}
let card3 = {number = Three; symbol = Round; shading = Full; colour = Green}
The final function returns a boolean for verifying the set:
> isSet card1 card2 card3
val it : bool = true
beginner f#
asked 11 mins ago
Vermillion
4881517
add a comment |
The game of Set involves cards with four properties: number, symbol, shading, and colour.
Three cards make a "Set" if the property is either all the same or all different across the three cards, for each of the four properties.
I wrote some code to verify if three cards constitute a "Set". But I'm not satisfied with the final function isSet. I feel there should be some way to iterate over the four properties instead of writing four separate lines. Any help would be appreciated - I'm fairly new to F#.
type Number = | One | Two | Three
type Symbol = | Round | Wavy | Diamond
type Shading = | Empty | Lines | Full
type Colour = | Red | Green | Blue
type Card = {number: Number;
symbol: Symbol;
shading: Shading;
colour: Colour}
let all =
List.reduce (=)
let numUnique list =
list
|> List.distinct
|> List.length
let allSame list =
list
|> numUnique
|> (=) 1
let allUnique list =
let length = List.length list
list
|> numUnique
|> (=) length
let allSameOrUnique list =
allSame list || allUnique list
let isSet card1 card2 card3 =
let check1 = allSameOrUnique [card1.number; card2.number; card3.number]
let check2 = allSameOrUnique [card1.symbol; card2.symbol; card3.symbol]
let check3 = allSameOrUnique [card1.shading; card2.shading; card3.shading]
let check4 = allSameOrUnique [card1.colour; card2.colour; card3.colour]
all [check1; check2; check3; check3; check4]
let card1 = {number = Two; symbol = Round; shading = Lines; colour = Green}
let card2 = {number = One; symbol = Round; shading = Empty; colour = Green}
let card3 = {number = Three; symbol = Round; shading = Full; colour = Green}
The final function returns a boolean for verifying the set:
> isSet card1 card2 card3
val it : bool = true
beginner f#
asked 11 mins ago
Vermillion
4881517
The game of Set involves cards with four properties: number, symbol, shading, and colour.
Three cards make a "Set" if the property is either all the same or all different across the three cards, for each of the four properties.
I wrote some code to verify if three cards constitute a "Set". But I'm not satisfied with the final function isSet. I feel there should be some way to iterate over the four properties instead of writing four separate lines. Any help would be appreciated - I'm fairly new to F#.
type Number = | One | Two | Three
type Symbol = | Round | Wavy | Diamond
type Shading = | Empty | Lines | Full
type Colour = | Red | Green | Blue
type Card = {number: Number;
symbol: Symbol;
shading: Shading;
colour: Colour}
let all =
List.reduce (=)
let numUnique list =
list
|> List.distinct
|> List.length
let allSame list =
list
|> numUnique
|> (=) 1
let allUnique list =
let length = List.length list
list
|> numUnique
|> (=) length
let allSameOrUnique list =
allSame list || allUnique list
let isSet card1 card2 card3 =
let check1 = allSameOrUnique [card1.number; card2.number; card3.number]
let check2 = allSameOrUnique [card1.symbol; card2.symbol; card3.symbol]
let check3 = allSameOrUnique [card1.shading; card2.shading; card3.shading]
let check4 = allSameOrUnique [card1.colour; card2.colour; card3.colour]
all [check1; check2; check3; check3; check4]
let card1 = {number = Two; symbol = Round; shading = Lines; colour = Green}
let card2 = {number = One; symbol = Round; shading = Empty; colour = Green}
let card3 = {number = Three; symbol = Round; shading = Full; colour = Green}
The final function returns a boolean for verifying the set:
> isSet card1 card2 card3
val it : bool = true
beginner f#
beginner f#
asked 11 mins ago
Vermillion
4881517
asked 11 mins ago
Vermillion
4881517
asked 11 mins ago
Vermillion
4881517
asked 11 mins ago
Vermillion
4881517
asked 11 mins ago
Vermillion
4881517
4881517
add a comment |
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210087%2fverifying-a-set-card-game-in-f%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210087%2fverifying-a-set-card-game-in-f%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
