Laravel Controller function to return view based on user permission











up vote
0
down vote

favorite
1












I have one route that switches the routes based on the permission the user has. Here is a little example:



public function show(Company $company)
{
if(auth()->user()->hasPermission('read-companies')) {
return view('portal.company.showAdmin', compact('company'));
} elseif (auth()->user()->hasPermission('read-company') && auth()->user()->companies->contains($company)) {
return view('portal.company.showEntrepreneur', compact('company'));
} elseif(auth()->user()->hasPermission('read-companies_v') && $company->visible()) {
return view('portal.company.showTrainee', compact('company'));
} else {
abort('403');
}
}


This basicly returns to 3 views based on the permissions of the user. A lot of my controller functions look like this. Now my question: Is this "One controller/route for multiple actions" approach a bad Idea? What if I want to add a role to the auth()->user()->companies->contains($company) many to many relationship? I would need to add all my controller functions. Is it better to have a function on the user model like IsAbleToShowOnCompany($company)? But than I would have houndreads of functions like that, because, e.g., Companys can create pokes, and I would need to check if the role of the many to many relation to company would allow that.



Do you have any refactor Ideas?



I've heard about service and repository classes, but how can I refactor this into a servivce?










share|improve this question




























    up vote
    0
    down vote

    favorite
    1












    I have one route that switches the routes based on the permission the user has. Here is a little example:



    public function show(Company $company)
    {
    if(auth()->user()->hasPermission('read-companies')) {
    return view('portal.company.showAdmin', compact('company'));
    } elseif (auth()->user()->hasPermission('read-company') && auth()->user()->companies->contains($company)) {
    return view('portal.company.showEntrepreneur', compact('company'));
    } elseif(auth()->user()->hasPermission('read-companies_v') && $company->visible()) {
    return view('portal.company.showTrainee', compact('company'));
    } else {
    abort('403');
    }
    }


    This basicly returns to 3 views based on the permissions of the user. A lot of my controller functions look like this. Now my question: Is this "One controller/route for multiple actions" approach a bad Idea? What if I want to add a role to the auth()->user()->companies->contains($company) many to many relationship? I would need to add all my controller functions. Is it better to have a function on the user model like IsAbleToShowOnCompany($company)? But than I would have houndreads of functions like that, because, e.g., Companys can create pokes, and I would need to check if the role of the many to many relation to company would allow that.



    Do you have any refactor Ideas?



    I've heard about service and repository classes, but how can I refactor this into a servivce?










    share|improve this question


























      up vote
      0
      down vote

      favorite
      1









      up vote
      0
      down vote

      favorite
      1






      1





      I have one route that switches the routes based on the permission the user has. Here is a little example:



      public function show(Company $company)
      {
      if(auth()->user()->hasPermission('read-companies')) {
      return view('portal.company.showAdmin', compact('company'));
      } elseif (auth()->user()->hasPermission('read-company') && auth()->user()->companies->contains($company)) {
      return view('portal.company.showEntrepreneur', compact('company'));
      } elseif(auth()->user()->hasPermission('read-companies_v') && $company->visible()) {
      return view('portal.company.showTrainee', compact('company'));
      } else {
      abort('403');
      }
      }


      This basicly returns to 3 views based on the permissions of the user. A lot of my controller functions look like this. Now my question: Is this "One controller/route for multiple actions" approach a bad Idea? What if I want to add a role to the auth()->user()->companies->contains($company) many to many relationship? I would need to add all my controller functions. Is it better to have a function on the user model like IsAbleToShowOnCompany($company)? But than I would have houndreads of functions like that, because, e.g., Companys can create pokes, and I would need to check if the role of the many to many relation to company would allow that.



      Do you have any refactor Ideas?



      I've heard about service and repository classes, but how can I refactor this into a servivce?










      share|improve this question















      I have one route that switches the routes based on the permission the user has. Here is a little example:



      public function show(Company $company)
      {
      if(auth()->user()->hasPermission('read-companies')) {
      return view('portal.company.showAdmin', compact('company'));
      } elseif (auth()->user()->hasPermission('read-company') && auth()->user()->companies->contains($company)) {
      return view('portal.company.showEntrepreneur', compact('company'));
      } elseif(auth()->user()->hasPermission('read-companies_v') && $company->visible()) {
      return view('portal.company.showTrainee', compact('company'));
      } else {
      abort('403');
      }
      }


      This basicly returns to 3 views based on the permissions of the user. A lot of my controller functions look like this. Now my question: Is this "One controller/route for multiple actions" approach a bad Idea? What if I want to add a role to the auth()->user()->companies->contains($company) many to many relationship? I would need to add all my controller functions. Is it better to have a function on the user model like IsAbleToShowOnCompany($company)? But than I would have houndreads of functions like that, because, e.g., Companys can create pokes, and I would need to check if the role of the many to many relation to company would allow that.



      Do you have any refactor Ideas?



      I've heard about service and repository classes, but how can I refactor this into a servivce?







      php laravel controller authorization






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited 2 days ago









      200_success

      127k15148412




      127k15148412










      asked 2 days ago









      KuebelElch15

      1063




      1063



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f208783%2flaravel-controller-function-to-return-view-based-on-user-permission%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f208783%2flaravel-controller-function-to-return-view-based-on-user-permission%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          List directoties down one level, excluding some named directories and files

          list processes belonging to a network namespace

          list systemd RuntimeDirectory mounts